From: Mark Brown <broonie@kernel.org>
To: David Miller <davem@davemloft.net>
Cc: jon@ringle.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] regmap: Allow installing custom reg_update_bits function
Date: Tue, 6 Oct 2015 10:57:15 +0100 [thread overview]
Message-ID: <20151006095715.GF12635@sirena.org.uk> (raw)
In-Reply-To: <20151005.232148.28609721470208031.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
On Mon, Oct 05, 2015 at 11:21:48PM -0700, David Miller wrote:
> > Ugh, this is a mess :( Can you please drop this patch instead?
> I can't just "drop" changes. Once a commit hits my tree it is part
> of the permanent record.
I was expecting a revert if you want to keep the branch fast forward
only.
> The easiest thing to do is to send a relative fix, and that's why
> I have asked for exactly that.
This isn't very good for reviewing the API change, and of course I'd
also expect this change to be in the regmap tree so we can work on
regmap without collisions, I obviously can't just merge in net-next.
I was thinking about making some further changes on top of this and it
*is* fiddling about in the core.
Jon, please send me a patch against the regmap tree for review while we
work out how to sort out this mess.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2015-10-06 9:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 11:43 [PATCH net-next v2 1/2] regmap: Allow installing custom reg_update_bits function jon
2015-10-01 11:43 ` [PATCH net-next v2 2/2] net: Microchip encx24j600 driver jon
2015-10-01 12:26 ` [RFC PATCH] net: encx24j600_exit() can be static kbuild test robot
2015-10-05 10:54 ` [PATCH net-next v2 2/2] net: Microchip encx24j600 driver David Miller
2015-10-05 11:00 ` David Miller
2015-10-05 11:01 ` David Miller
2015-10-05 10:54 ` [PATCH net-next v2 1/2] regmap: Allow installing custom reg_update_bits function David Miller
2015-10-05 11:57 ` Jon Ringle
2015-10-05 13:16 ` David Miller
2015-10-05 14:25 ` Mark Brown
2015-10-06 6:21 ` David Miller
2015-10-06 9:57 ` Mark Brown [this message]
2015-10-06 13:22 ` David Miller
2015-10-06 15:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151006095715.GF12635@sirena.org.uk \
--to=broonie@kernel.org \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=jon@ringle.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox