From: Jiri Pirko <jiri@resnulli.us>
To: Arnd Bergmann <arnd@arndb.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Jiri Pirko <jiri@mellanox.com>,
Ido Schimmel <idosch@mellanox.com>,
linux-kernel@vger.kernel.org, Elad Raz <eladr@mellanox.com>,
Scott Feldman <sfeldma@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t
Date: Wed, 7 Oct 2015 08:43:31 +0200 [thread overview]
Message-ID: <20151007064331.GC2152@nanopsycho.orion> (raw)
In-Reply-To: <30258520.VaA2vDyUiY@wuerfel>
Tue, Oct 06, 2015 at 11:47:44PM CEST, arnd@arndb.de wrote:
>The recently added mlxsw driver produces warnings in ARM
>allmodconfig:
>
>drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec':
>drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count >= width of type [-Wshift-count-overflow]
>linux/byteorder/big_endian.h:38:51: note: in definition of macro '__cpu_to_be32'
>drivers/net/ethernet/mellanox/mlxsw/pci.c:76:2: note: in expansion of macro 'iowrite32be'
>
>This changes the type of the local variable to u64, which gets rid of the
>warning and seems nicer than adding #ifdefs.
>
>Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>Fixes: eda6500a987a "mlxsw: Add PCI bus implementation"
Acked-by: Jiri Pirko <jiri@mellanox.com>
Thanks!
next prev parent reply other threads:[~2015-10-07 6:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 21:47 [PATCH] mlxsw: fix warnings for big-endian 32-bit dma_addr_t Arnd Bergmann
2015-10-07 6:43 ` Jiri Pirko [this message]
2015-10-07 6:53 ` Joe Perches
2015-10-07 6:56 ` Jiri Pirko
2015-10-07 6:58 ` [PATCH v2] " Arnd Bergmann
2015-10-07 7:00 ` Jiri Pirko
2015-10-08 12:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007064331.GC2152@nanopsycho.orion \
--to=jiri@resnulli.us \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox