From: Christoph Hellwig <hch@lst.de>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>,
Christoph Hellwig <hch@lst.de>,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] samples: build configfs sample on when enabled
Date: Mon, 12 Oct 2015 16:20:28 +0200 [thread overview]
Message-ID: <20151012142028.GA24695@lst.de> (raw)
In-Reply-To: <6271650.CdczvJuMsL@wuerfel>
On Mon, Oct 12, 2015 at 04:14:16PM +0200, Arnd Bergmann wrote:
> Most samples have their own Kconfig option, but for some reason
> the configfs sample does not have one and gets built unconditionally
> when CONFIG_SAMPLES is enabled, which fails if CONFIG_CONFIGFS_FS
> is not:
>
> ERROR: "configfs_unregister_subsystem" [samples/configfs/configfs_sample.ko] undefined!
> ERROR: "configfs_register_subsystem" [samples/configfs/configfs_sample.ko] undefined!
>
> This adds a new Kconfig symbol to mirror the existing method and
> only let the user enable this sample if configfs is present.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This should already be in version two of the series I sent last week.
prev parent reply other threads:[~2015-10-12 14:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 14:14 [PATCH] samples: build configfs sample on when enabled Arnd Bergmann
2015-10-12 14:20 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012142028.GA24695@lst.de \
--to=hch@lst.de \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox