From: Jean Delvare <jdelvare@suse.de>
To: Huang Rui <ray.huang@amd.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
kbuild test robot <lkp@intel.com>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
Fengguang Wu <fengguang.wu@intel.com>, <kbuild-all@01.org>,
Borislav Petkov <bp@suse.de>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@amacapital.net>,
Andreas Herrmann <herrmann.der.user@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
"John Stultz" <john.stultz@linaro.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
<lm-sensors@lm-sensors.org>, <linux-kernel@vger.kernel.org>,
<x86@kernel.org>,
Andreas Herrmann <herrmann.der.user@googlemail.com>,
Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>,
Borislav Petkov <bp@alien8.de>, Aaron Lu <aaron.lu@intel.com>,
Tony Li <tony.li@amd.com>
Subject: Re: [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power
Date: Wed, 21 Oct 2015 08:05:20 +0200 [thread overview]
Message-ID: <20151021080520.30f28ce9@endymion.delvare> (raw)
In-Reply-To: <20151021030400.GC26968@hr-amur2>
Hi Rui,
On Wed, 21 Oct 2015 11:04:01 +0800, Huang Rui wrote:
> On Tue, Oct 20, 2015 at 07:49:53PM -0700, Guenter Roeck wrote:
> > On 10/20/2015 07:40 PM, Huang Rui wrote:
> > >>>Thanks to report this issue. :)
> > >>>The root cause is that the test config doesn't enable
> > >>>CONFIG_CPU_SUP_AMD.
> > >>>
> > >>>How about below fix:
> > >>>
> > >>
> > >>Guess you don't have a choice.
> > >>
> > >
> > >Yes, if I use test config, fam15h_power isn't chosen. :)
> > >
> > >And if I use the "select" flag like below, fam15h_power can be built
> > >successfully.
> > >
> > That is another possibility, though that isn't how CPU_SUP_AMD
> > is handled by its other users. Matter of philosophy, I guess.
>
> Err, sorry. Could you please point out the other possibility?
Both possibilities came from you. First one is to use "depends", second
one is to use "select".
As pointed out bu Gunter, other drivers (EDAC_DECODE_MCE, MICROCODE,
AMD_NB) use "depends" so you should do the same for consistency.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2015-10-21 6:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 2:28 [PATCH v2 00/10] hwmon: (fam15h_power) Introduce an accumulated power reporting algorithm Huang Rui
2015-10-20 2:28 ` [PATCH v2 01/10] hwmon: (fam15h_power) Refactor attributes for dynamically added Huang Rui
2015-10-23 13:42 ` Guenter Roeck
2015-10-26 1:58 ` Huang Rui
2015-10-26 2:14 ` Guenter Roeck
2015-10-26 2:25 ` Huang Rui
2015-10-20 2:28 ` [PATCH v2 02/10] hwmon: (fam15h_power) Enable power1_input on AMD Carrizo Huang Rui
2015-10-23 13:45 ` Guenter Roeck
2015-10-26 2:19 ` Huang Rui
2015-10-20 2:28 ` [PATCH v2 03/10] hwmon: (fam15h_power) Add max compute unit accumulated power Huang Rui
2015-10-20 2:28 ` [PATCH v2 04/10] x86, amd: add accessor for number of cores per compute unit Huang Rui
2015-10-20 2:28 ` [PATCH v2 05/10] hwmon: (fam15h_power) Add compute unit accumulated power Huang Rui
2015-10-20 7:24 ` kbuild test robot
2015-10-21 1:42 ` Huang Rui
2015-10-21 2:15 ` Guenter Roeck
2015-10-21 2:40 ` Huang Rui
2015-10-21 2:49 ` Guenter Roeck
2015-10-21 3:04 ` Huang Rui
2015-10-21 6:05 ` Jean Delvare [this message]
2015-10-21 6:28 ` Huang Rui
2015-10-23 13:27 ` Borislav Petkov
2015-10-23 13:37 ` Guenter Roeck
2015-10-27 2:53 ` Huang Rui
2015-10-28 0:34 ` Borislav Petkov
2015-10-28 5:06 ` Huang Rui
2015-10-20 2:28 ` [PATCH v2 06/10] hwmon: (fam15h_power) Add ptsc counter value for " Huang Rui
2015-10-23 13:59 ` Guenter Roeck
2015-10-26 3:37 ` Huang Rui
2015-10-26 4:36 ` Borislav Petkov
2015-10-20 2:28 ` [PATCH v2 07/10] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm Huang Rui
2015-10-23 13:28 ` Borislav Petkov
2015-10-26 3:46 ` Huang Rui
2015-10-26 4:41 ` Borislav Petkov
2015-10-23 14:20 ` Guenter Roeck
2015-10-27 3:36 ` Huang Rui
2015-10-20 2:28 ` [PATCH v2 08/10] hwmon: (fam15h_power) Add documentation for previous TDP reporting Huang Rui
2015-10-20 2:28 ` [PATCH v2 09/10] hwmon: (fam15h_power) Add documentation for accumulated power algorithm Huang Rui
2015-10-23 10:22 ` Borislav Petkov
2015-10-20 2:28 ` [PATCH v2 10/10] MAINTAINERS: change the maintainer of fam15h_power driver Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021080520.30f28ce9@endymion.delvare \
--to=jdelvare@suse.de \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=aaron.lu@intel.com \
--cc=bp@alien8.de \
--cc=bp@suse.de \
--cc=fengguang.wu@intel.com \
--cc=fweisbec@gmail.com \
--cc=herrmann.der.user@gmail.com \
--cc=herrmann.der.user@googlemail.com \
--cc=john.stultz@linaro.org \
--cc=kbuild-all@01.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=lkp@intel.com \
--cc=lm-sensors@lm-sensors.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=ray.huang@amd.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=tony.li@amd.com \
--cc=x86@kernel.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox