From: Greg KH <gregkh@linuxfoundation.org>
To: dave penkler <dpenkler@gmail.com>
Cc: peter.chen@freescale.com, teuniz@gmail.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] USB: usbtmc: Add support for missing USBTMC-USB488 spec
Date: Sat, 24 Oct 2015 19:52:33 -0700 [thread overview]
Message-ID: <20151025025233.GB25874@kroah.com> (raw)
In-Reply-To: <20151019073320.GA5541@slacky>
On Mon, Oct 19, 2015 at 09:33:20AM +0200, dave penkler wrote:
>
> Implement support for the USB488 defined READ_STATUS_BYTE and SRQ
> notifications with ioctl, fasync and poll/select in order to be able
> to synchronize with variable duration instrument operations.
>
> Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and
> LOCAL_LOCKOUT.
>
> Add convenience ioctl to return all device capabilities.
Can you break this up into a series of patches, all doing only one
thing? You are doing a lot of different things in this single patch,
making it almost impossible to review :(
thanks,
greg k-h
prev parent reply other threads:[~2015-10-25 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 7:33 [PATCH V2] USB: usbtmc: Add support for missing USBTMC-USB488 spec dave penkler
2015-10-25 2:52 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151025025233.GB25874@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dpenkler@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@freescale.com \
--cc=teuniz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox