From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Adam Sampson <ats@offog.org>
Cc: lgirdwood@gmail.com, broonie@kernel.org, emilio@elopez.com.ar,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH] ASoC: sun4i-codec: use consistent names for PA controls
Date: Tue, 27 Oct 2015 19:27:06 +0100 [thread overview]
Message-ID: <20151027182706.GE6114@lukather> (raw)
In-Reply-To: <1445688712-31951-1-git-send-email-ats@offog.org>
[-- Attachment #1: Type: text/plain, Size: 894 bytes --]
Hi,
On Sat, Oct 24, 2015 at 01:11:52PM +0100, Adam Sampson wrote:
> The power amplifier for the headphone output is called "the PA" and "the
> headphone amplifier" in Allwinner's documentation for the A10 and A20.
> sun4i-codec calls it "PA" in some places and "Pre-Amplifier" (which
> isn't really accurate) in others, leading to user-visible controls with
> different names referring to the same device.
>
> When this driver implements audio input, it'll also need to expose
> controls for the line and mic input preamps, so just referring to "the
> Pre-Amplifier" will be ambiguous.
>
> Change it to use "PA" consistently for the power amplifier.
Just to avoid any ambiguity in the future, could you call that Power
Amp(lifier?) instead?
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2015-10-27 18:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-24 12:11 [PATCH] ASoC: sun4i-codec: use consistent names for PA controls Adam Sampson
2015-10-27 18:27 ` Maxime Ripard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151027182706.GE6114@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=alsa-devel@alsa-project.org \
--cc=ats@offog.org \
--cc=broonie@kernel.org \
--cc=emilio@elopez.com.ar \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox