* [PATCH] mfd: qcom_rpm: fix a possible NULL dereference
@ 2015-11-12 7:49 LABBE Corentin
2015-11-24 16:46 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: LABBE Corentin @ 2015-11-12 7:49 UTC (permalink / raw)
To: lee.jones; +Cc: LABBE Corentin, linux-kernel
of_match_device could return NULL, and so cause a NULL pointer
dereference later.
Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
---
drivers/mfd/qcom_rpm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
index 207a3bd..1be47ad 100644
--- a/drivers/mfd/qcom_rpm.c
+++ b/drivers/mfd/qcom_rpm.c
@@ -495,6 +495,8 @@ static int qcom_rpm_probe(struct platform_device *pdev)
}
match = of_match_device(qcom_rpm_of_match, &pdev->dev);
+ if (!match)
+ return -ENODEV;
rpm->data = match->data;
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
--
2.4.10
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mfd: qcom_rpm: fix a possible NULL dereference
2015-11-12 7:49 [PATCH] mfd: qcom_rpm: fix a possible NULL dereference LABBE Corentin
@ 2015-11-24 16:46 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2015-11-24 16:46 UTC (permalink / raw)
To: LABBE Corentin; +Cc: linux-kernel
On Thu, 12 Nov 2015, LABBE Corentin wrote:
> of_match_device could return NULL, and so cause a NULL pointer
> dereference later.
>
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> ---
> drivers/mfd/qcom_rpm.c | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks.
> diff --git a/drivers/mfd/qcom_rpm.c b/drivers/mfd/qcom_rpm.c
> index 207a3bd..1be47ad 100644
> --- a/drivers/mfd/qcom_rpm.c
> +++ b/drivers/mfd/qcom_rpm.c
> @@ -495,6 +495,8 @@ static int qcom_rpm_probe(struct platform_device *pdev)
> }
>
> match = of_match_device(qcom_rpm_of_match, &pdev->dev);
> + if (!match)
> + return -ENODEV;
> rpm->data = match->data;
>
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-24 16:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-12 7:49 [PATCH] mfd: qcom_rpm: fix a possible NULL dereference LABBE Corentin
2015-11-24 16:46 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox