* [PATCH] efi/esrt: don't preformat name
@ 2015-11-20 10:30 Rasmus Villemoes
2015-11-26 10:27 ` Matt Fleming
0 siblings, 1 reply; 2+ messages in thread
From: Rasmus Villemoes @ 2015-11-20 10:30 UTC (permalink / raw)
To: Matt Fleming; +Cc: Rasmus Villemoes, linux-efi, linux-kernel
kobject_init_and_add takes a format string+args, so there's no reason
to do this formatting in advance.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
drivers/firmware/efi/esrt.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
index 22c5285f7705..75feb3f5829b 100644
--- a/drivers/firmware/efi/esrt.c
+++ b/drivers/firmware/efi/esrt.c
@@ -167,14 +167,11 @@ static struct kset *esrt_kset;
static int esre_create_sysfs_entry(void *esre, int entry_num)
{
struct esre_entry *entry;
- char name[20];
entry = kzalloc(sizeof(*entry), GFP_KERNEL);
if (!entry)
return -ENOMEM;
- sprintf(name, "entry%d", entry_num);
-
entry->kobj.kset = esrt_kset;
if (esrt->fw_resource_version == 1) {
@@ -182,7 +179,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num)
entry->esre.esre1 = esre;
rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL,
- "%s", name);
+ "entry%d", entry_num);
if (rc) {
kfree(entry);
return rc;
--
2.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] efi/esrt: don't preformat name
2015-11-20 10:30 [PATCH] efi/esrt: don't preformat name Rasmus Villemoes
@ 2015-11-26 10:27 ` Matt Fleming
0 siblings, 0 replies; 2+ messages in thread
From: Matt Fleming @ 2015-11-26 10:27 UTC (permalink / raw)
To: Rasmus Villemoes; +Cc: linux-efi, linux-kernel, Peter Jones
On Fri, 20 Nov, at 11:30:17AM, Rasmus Villemoes wrote:
> kobject_init_and_add takes a format string+args, so there's no reason
> to do this formatting in advance.
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> drivers/firmware/efi/esrt.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
Looks good to me. Thanks applied!
> diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c
> index 22c5285f7705..75feb3f5829b 100644
> --- a/drivers/firmware/efi/esrt.c
> +++ b/drivers/firmware/efi/esrt.c
> @@ -167,14 +167,11 @@ static struct kset *esrt_kset;
> static int esre_create_sysfs_entry(void *esre, int entry_num)
> {
> struct esre_entry *entry;
> - char name[20];
>
> entry = kzalloc(sizeof(*entry), GFP_KERNEL);
> if (!entry)
> return -ENOMEM;
>
> - sprintf(name, "entry%d", entry_num);
> -
> entry->kobj.kset = esrt_kset;
>
> if (esrt->fw_resource_version == 1) {
> @@ -182,7 +179,7 @@ static int esre_create_sysfs_entry(void *esre, int entry_num)
>
> entry->esre.esre1 = esre;
> rc = kobject_init_and_add(&entry->kobj, &esre1_ktype, NULL,
> - "%s", name);
> + "entry%d", entry_num);
> if (rc) {
> kfree(entry);
> return rc;
> --
> 2.6.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-26 10:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-20 10:30 [PATCH] efi/esrt: don't preformat name Rasmus Villemoes
2015-11-26 10:27 ` Matt Fleming
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox