From: Minchan Kim <minchan@kernel.org>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH 2/2] zram/zcomp: do not zero out zcomp private pages
Date: Mon, 30 Nov 2015 16:14:28 +0900 [thread overview]
Message-ID: <20151130071428.GC3262@bbox> (raw)
In-Reply-To: <1448598194-24754-3-git-send-email-sergey.senozhatsky@gmail.com>
On Fri, Nov 27, 2015 at 01:23:14PM +0900, Sergey Senozhatsky wrote:
> Do not __GFP_ZERO allocated zcomp ->private pages. We keep
> allocated streams around and use them for read/write requests,
> so we supply a zeroed out ->private to compression algorithm
> as a scratch buffer only once -- the first time we use that
> stream. For the rest of IO requests served by this stream
> ->private usually contains some temporarily data from the
> previous requests.
>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Thanks.
prev parent reply other threads:[~2015-11-30 7:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-27 4:23 [PATCH 0/2] zram: cleanup stream's ->private allocation code Sergey Senozhatsky
2015-11-27 4:23 ` [PATCH 1/2] zram: pass gfp from zcomp frontend to backend Sergey Senozhatsky
2015-12-01 0:10 ` Andrew Morton
2015-12-01 0:44 ` Sergey Senozhatsky
2015-11-27 4:23 ` [PATCH 2/2] zram/zcomp: do not zero out zcomp private pages Sergey Senozhatsky
2015-11-30 7:14 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130071428.GC3262@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox