* [PATCH] ASoC: wm8974: set cache type for regmap
@ 2015-12-11 11:27 Mans Rullgard
2015-12-11 12:54 ` Charles Keepax
0 siblings, 1 reply; 2+ messages in thread
From: Mans Rullgard @ 2015-12-11 11:27 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, patches,
alsa-devel, linux-kernel
Attempting to use this codec driver triggers a BUG() in regcache_sync()
since no cache type is set. The register map of this device is fairly
small and has few holes so a flat cache is suitable.
Signed-off-by: Mans Rullgard <mans@mansr.com>
---
sound/soc/codecs/wm8974.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/soc/codecs/wm8974.c b/sound/soc/codecs/wm8974.c
index 45ba828..c284c7b 100644
--- a/sound/soc/codecs/wm8974.c
+++ b/sound/soc/codecs/wm8974.c
@@ -574,6 +574,7 @@ static const struct regmap_config wm8974_regmap = {
.max_register = WM8974_MONOMIX,
.reg_defaults = wm8974_reg_defaults,
.num_reg_defaults = ARRAY_SIZE(wm8974_reg_defaults),
+ .cache_type = REGCACHE_FLAT,
};
static int wm8974_probe(struct snd_soc_codec *codec)
--
2.6.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: wm8974: set cache type for regmap
2015-12-11 11:27 [PATCH] ASoC: wm8974: set cache type for regmap Mans Rullgard
@ 2015-12-11 12:54 ` Charles Keepax
0 siblings, 0 replies; 2+ messages in thread
From: Charles Keepax @ 2015-12-11 12:54 UTC (permalink / raw)
To: Mans Rullgard
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai, patches,
alsa-devel, linux-kernel
On Fri, Dec 11, 2015 at 11:27:08AM +0000, Mans Rullgard wrote:
> Attempting to use this codec driver triggers a BUG() in regcache_sync()
> since no cache type is set. The register map of this device is fairly
> small and has few holes so a flat cache is suitable.
>
> Signed-off-by: Mans Rullgard <mans@mansr.com>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-11 12:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-11 11:27 [PATCH] ASoC: wm8974: set cache type for regmap Mans Rullgard
2015-12-11 12:54 ` Charles Keepax
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox