Re: [lm-sensors] LM90 driver and ti tmp461 detection

Re: [lm-sensors] LM90 driver and ti tmp461 detection

[Jean Delvare]

Hallo Andreas,

On Thu, 10 Dec 2015 18:12:31 +0100, Andreas Werner wrote:
> thanks for the register dump :-)

Can you please share the register dump of your TMP461 with us?

Thanks,
-- 
Jean Delvare
SUSE L3 Support

Re: [lm-sensors] LM90 driver and ti tmp461 detection

[Andreas Werner]

>Hallo Andreas,
>
> On Thu, 10 Dec 2015 18:12:31 +0100, Andreas Werner wrote:
>> thanks for the register dump
>
> Can you please share the register dump of your TMP461 with us?
>

Hi,
yes for sure. Currently i have just a evaluation board my CPU without
this sensor, but I have received a tmp461 yesterday. 

As soon as I have soldered this sensor to the Eval board, I will send
a register dump.

Regards
Andy

Re: [lm-sensors] LM90 driver and ti tmp461 detection

[Andreas Werner]

On Sat, Dec 12, 2015 at 11:08:42AM +0100, Jean Delvare wrote:
> Hallo Andreas,
> 
> On Thu, 10 Dec 2015 18:12:31 +0100, Andreas Werner wrote:
> > thanks for the register dump :-)
> 
> Can you please share the register dump of your TMP461 with us?
> 
> Thanks,
> -- 
> Jean Delvare
> SUSE L3 Support

Hi,
here is the register dump of the tmp461.
It seemse that we really cannot detect if it is a tmp461 or a tmp451.
Also the magic "ID Register" offset 0xff is 0x00 for both devices.

     0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f    0123456789abcdef
00: 5a 00 2c 00 05 7f 80 7f 80 00 00 00 00 00 00 00    Z.,.?????.......
10: 00 00 00 f0 00 80 03 00 00 7f 00 00 00 00 00 00    ...?.??..?......
20: 7f 0a 01 00 00 XX 00 00 00 00 0e 00 00 00 40 00    ???..X....?...@.
30: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
80: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
90: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00    ................
f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 55 00    ..............U.

Regards
Andy

Re: [lm-sensors] LM90 driver and ti tmp461 detection

[Jean Delvare]

Hi Andreas,

On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote:
> here is the register dump of the tmp461.

Thanks.

> It seemse that we really cannot detect if it is a tmp461 or a tmp451.
> Also the magic "ID Register" offset 0xff is 0x00 for both devices.

I would use register 0x16, which doesn't exist but reads 0x00 on the
TMP451. It could in theory also read 0x00 on the TMP461 but only if
both channels are disabled, which makes little sense. More likely at
least one channel will be enabled so you'll have value 0x01-0x03 if
this is a TMP461.

-- 
Jean Delvare
SUSE L3 Support

Re: [lm-sensors] LM90 driver and ti tmp461 detection

[Andreas Werner]

On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote:
> Hi Andreas,
> 
> On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote:
> > here is the register dump of the tmp461.
> 
> Thanks.
> 
> > It seemse that we really cannot detect if it is a tmp461 or a tmp451.
> > Also the magic "ID Register" offset 0xff is 0x00 for both devices.
> 
> I would use register 0x16, which doesn't exist but reads 0x00 on the
> TMP451. It could in theory also read 0x00 on the TMP461 but only if
> both channels are disabled, which makes little sense. More likely at
> least one channel will be enabled so you'll have value 0x01-0x03 if
> this is a TMP461.
>

Yes you are right. Both channels are enabled during POR, so the chance
to have a 0x00 as in the TMP451 will be very low.
 
> -- 
> Jean Delvare
> SUSE L3 Support

Re: [lm-sensors] LM90 driver and ti tmp461 detection

[Guenter Roeck]

On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote:
> Hi Andreas,
> 
> On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote:
> > here is the register dump of the tmp461.
> 
> Thanks.
> 
> > It seemse that we really cannot detect if it is a tmp461 or a tmp451.
> > Also the magic "ID Register" offset 0xff is 0x00 for both devices.
> 
> I would use register 0x16, which doesn't exist but reads 0x00 on the
> TMP451. It could in theory also read 0x00 on the TMP461 but only if
> both channels are disabled, which makes little sense. More likely at
> least one channel will be enabled so you'll have value 0x01-0x03 if
> this is a TMP461.
> 
Excellent idea!

Guenter

Re: [lm-sensors] LM90 driver and ti tmp461 detection

[Andreas Werner]

On Thu, Dec 17, 2015 at 06:57:51AM -0800, Guenter Roeck wrote:
> On Thu, Dec 17, 2015 at 12:48:08PM +0100, Jean Delvare wrote:
> > Hi Andreas,
> > 
> > On Tue, 15 Dec 2015 16:11:24 +0100, Andreas Werner wrote:
> > > here is the register dump of the tmp461.
> > 
> > Thanks.
> > 
> > > It seemse that we really cannot detect if it is a tmp461 or a tmp451.
> > > Also the magic "ID Register" offset 0xff is 0x00 for both devices.
> > 
> > I would use register 0x16, which doesn't exist but reads 0x00 on the
> > TMP451. It could in theory also read 0x00 on the TMP461 but only if
> > both channels are disabled, which makes little sense. More likely at
> > least one channel will be enabled so you'll have value 0x01-0x03 if
> > this is a TMP461.
> > 
> Excellent idea!
> 
> Guenter

Ok, i will implement the detection for the tm461 and also the temp calculation
for setting the temperature value.

Will send a patch as soon as i am done.

Regards
Andy