* [PATCH] char: constify tty_port_operations structs
@ 2015-12-14 23:50 Aya Mahfouz
2015-12-15 11:17 ` Arnd Bergmann
0 siblings, 1 reply; 2+ messages in thread
From: Aya Mahfouz @ 2015-12-14 23:50 UTC (permalink / raw)
To: Arnd Bergmann, Greg Kroah-Hartman, Julia Lawall, linux-kernel
Constifies tty_port_operations structure in
the char driver since it is not modified
after its initialization.
Detected and found using Coccinelle.
Suggested-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>
---
drivers/char/ttyprintk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ttyprintk.c b/drivers/char/ttyprintk.c
index a15ce4e..b098d2d 100644
--- a/drivers/char/ttyprintk.c
+++ b/drivers/char/ttyprintk.c
@@ -171,7 +171,7 @@ static const struct tty_operations ttyprintk_ops = {
.ioctl = tpk_ioctl,
};
-static struct tty_port_operations null_ops = { };
+static const struct tty_port_operations null_ops = { };
static struct tty_driver *ttyprintk_driver;
--
2.4.3
--
Kind Regards,
Aya Saif El-yazal Mahfouz
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-12-15 11:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-14 23:50 [PATCH] char: constify tty_port_operations structs Aya Mahfouz
2015-12-15 11:17 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox