Re: [PATCH 07/10] perf tools: Add 'trace' sort key

[Namhyung Kim <namhyung@kernel.org>]

Hi Jiri,

On Tue, Dec 22, 2015 at 08:22:03AM +0100, Jiri Olsa wrote:
> On Mon, Dec 21, 2015 at 11:26:50PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > index e28d26d0e73c..50a6b35a2fee 100644
> > --- a/tools/perf/util/sort.c
> > +++ b/tools/perf/util/sort.c
> > @@ -445,6 +445,65 @@ struct sort_entry sort_socket = {
> >  	.se_width_idx	= HISTC_SOCKET,
> >  };
> >  
> > +/* --sort trace */
> > +
> > +static char *get_trace_output(struct hist_entry *he)
> > +{
> > +	struct trace_seq seq;
> > +	struct perf_evsel *evsel;
> > +	struct pevent_record rec = {
> > +		.data = he->raw_data,
> > +		.size = he->raw_size,
> > +	};
> > +
> > +	evsel = hists_to_evsel(he->hists);
> > +
> > +	trace_seq_init(&seq);
> > +	pevent_event_info(&seq, evsel->tp_format, &rec);
> > +	return seq.buffer;
> > +}
> 
> this function could be global and used in previous patch
> in update_dynamic_len for trace_output?

OK.

> 
> hum, one's using evsel->tp_format and the other field->event,
> I can't recall if both point to the same stuff..

AFAIK they should point to the same.

Thanks,
Namhyung