From: Hugo Camboulive <hugo.camboulive@gmail.com>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: gregkh@linuxfoundation.org, chaehyun.lim@gmail.com,
christian.gromm@microchip.com, andrey.shvetsov@k2l.de,
sudipm.mukherjee@gmail.com, joe@perches.com,
shraddha.6596@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: most: add __iomem for io_base and registers
Date: Sat, 2 Jan 2016 21:59:42 +0000 [thread overview]
Message-ID: <20160102215942.GA3847@hugo-core> (raw)
In-Reply-To: <20160102203322.GJ9938@ZenIV.linux.org.uk>
On Saturday 02 Jan 2016 20:33:23 (+0000), Al Viro wrote:
> On Sat, Jan 02, 2016 at 08:30:21PM +0000, Hugo Camboulive wrote:
> > This removes a few Sparse warnings.
>
> > + g.dim2 = (struct dim2_regs __iomem *)dim_base_address;
>
> > -u8 dim_startup(void *dim_base_address, u32 mlb_clock);
> > +u8 dim_startup(void __iomem *dim_base_address, u32 mlb_clock);
>
> Umm... Why not have it take struct dim2_regs __iomem * as argument, and
> to hell with that cast?
Oh, right. I wasn't sure if the original void* was there for a reason. I'll send a v2.
next prev parent reply other threads:[~2016-01-02 20:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-02 20:30 [PATCH] staging: most: add __iomem for io_base and registers Hugo Camboulive
2016-01-02 20:33 ` Al Viro
2016-01-02 21:59 ` Hugo Camboulive [this message]
2016-01-02 22:33 ` [PATCH v2] " Hugo Camboulive
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160102215942.GA3847@hugo-core \
--to=hugo.camboulive@gmail.com \
--cc=andrey.shvetsov@k2l.de \
--cc=chaehyun.lim@gmail.com \
--cc=christian.gromm@microchip.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shraddha.6596@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox