From: Tejun Heo <tj@kernel.org>
To: Parav Pandit <pandit.parav@gmail.com>
Cc: cgroups@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org,
lizefan@huawei.com, Johannes Weiner <hannes@cmpxchg.org>,
Doug Ledford <dledford@redhat.com>,
Liran Liss <liranl@mellanox.com>,
"Hefty, Sean" <sean.hefty@intel.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Haggai Eran <haggaie@mellanox.com>,
Jonathan Corbet <corbet@lwn.net>,
james.l.morris@oracle.com, serge@hallyn.com,
Or Gerlitz <ogerlitz@mellanox.com>,
Matan Barak <matanb@mellanox.com>,
raindel@mellanox.com, akpm@linux-foundation.org,
linux-security-module@vger.kernel.org
Subject: Re: [PATCHv1 6/6] rdmacg: Added documentation for rdma controller.
Date: Wed, 6 Jan 2016 17:57:14 -0500 [thread overview]
Message-ID: <20160106225714.GI3660@htj.duckdns.org> (raw)
In-Reply-To: <CAG53R5WD18VK3sVuVnPR7yjEBqRjHAoUkCpZKzSd9-PYZrx-YA@mail.gmail.com>
Hello,
On Thu, Jan 07, 2016 at 04:14:26AM +0530, Parav Pandit wrote:
> Yes. I read through. I can see two changes to be made in V2 version of
> this patch.
> 1. rdma.resource.verb.usage and rdma.resource.verb.limit to change
> respectively to,
> 2. rdma.resource.verb.stat and rdma.resource.verb.max.
> 3. rdma.resource.verb.failcnt indicate failure events, which I think
> should go to events.
What's up with the ".resource" part? Also can't the .max file list
the available resources? Why does it need a separtae list file?
> I roll out new patch for events post this patch as additional feature
> and remove this feature in V2.
>
> rdma.resource.verb.list file is unique to rdma cgroup, so I believe
> this is fine.
Please see above.
> We will conclude whether to have rdma.resource.hw.<files> or not in
> other patches.
> I am in opinion to keep "resource" and "verb" or "hw" tags around to
> keep it verbose enough to know what are we trying to control.
What does that achieve? I feel that it's getting overengineered
constantly.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-01-06 23:12 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 18:58 [PATCHv1 0/6] rdma controller support Parav Pandit
2016-01-05 18:58 ` [PATCHv1 1/6] rdmacg: Added rdma cgroup header file Parav Pandit
2016-01-05 18:58 ` [PATCHv1 2/6] IB/core: Added members to support rdma cgroup Parav Pandit
2016-01-05 21:56 ` Tejun Heo
2016-01-06 23:16 ` Parav Pandit
2016-01-07 15:07 ` Tejun Heo
2016-01-07 19:40 ` Parav Pandit
2016-01-05 18:58 ` [PATCHv1 3/6] rdmacg: implements " Parav Pandit
2016-01-05 22:01 ` Tejun Heo
2016-01-06 23:33 ` Parav Pandit
2016-01-07 15:29 ` Tejun Heo
2016-01-07 20:25 ` Parav Pandit
2016-01-07 20:28 ` Tejun Heo
2016-01-07 20:39 ` Parav Pandit
2016-01-07 20:41 ` Tejun Heo
2016-01-05 18:58 ` [PATCHv1 4/6] IB/core: rdmacg support infrastructure APIs Parav Pandit
2016-01-05 18:58 ` [PATCHv1 5/6] IB/core: use rdma cgroup for resource accounting Parav Pandit
2016-01-05 18:58 ` [PATCHv1 6/6] rdmacg: Added documentation for rdma controller Parav Pandit
2016-01-05 21:53 ` Tejun Heo
2016-01-06 22:44 ` Parav Pandit
2016-01-06 22:57 ` Tejun Heo [this message]
2016-01-06 23:52 ` Parav Pandit
2016-01-07 15:42 ` Tejun Heo
2016-01-07 19:43 ` Parav Pandit
2016-01-05 21:56 ` [PATCHv1 0/6] rdma controller support Tejun Heo
2016-01-06 23:13 ` Parav Pandit
2016-01-07 15:07 ` Tejun Heo
2016-01-07 20:01 ` Parav Pandit
2016-01-07 20:06 ` Tejun Heo
2016-01-07 20:32 ` Parav Pandit
2016-01-07 20:34 ` Tejun Heo
2016-01-07 20:46 ` Parav Pandit
2016-01-07 20:49 ` Tejun Heo
2016-01-07 20:50 ` Tejun Heo
2016-01-07 21:01 ` Parav Pandit
2016-01-07 21:07 ` Tejun Heo
2016-01-07 21:10 ` Parav Pandit
2016-01-07 21:04 ` Parav Pandit
2016-01-07 21:08 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160106225714.GI3660@htj.duckdns.org \
--to=tj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=corbet@lwn.net \
--cc=dledford@redhat.com \
--cc=haggaie@mellanox.com \
--cc=hannes@cmpxchg.org \
--cc=james.l.morris@oracle.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=liranl@mellanox.com \
--cc=lizefan@huawei.com \
--cc=matanb@mellanox.com \
--cc=ogerlitz@mellanox.com \
--cc=pandit.parav@gmail.com \
--cc=raindel@mellanox.com \
--cc=sean.hefty@intel.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox