From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Oreste Salerno <oreste.salerno@tomtom.com>
Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
fery@cypress.com, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/4] Input: cyttsp - use devres managed resource allocations
Date: Thu, 21 Jan 2016 11:29:24 -0800 [thread overview]
Message-ID: <20160121192924.GB39970@dtor-ws> (raw)
In-Reply-To: <20e9f0188f07fc420912b3defa747303be3cf290.1453403916.git.oreste.salerno@tomtom.com>
Hi Oreste,
On Thu, Jan 21, 2016 at 08:21:13PM +0100, Oreste Salerno wrote:
> Use devm_() functions for allocating memory, input device and IRQ.
>
...
> @@ -625,11 +620,8 @@ EXPORT_SYMBOL_GPL(cyttsp_probe);
>
> void cyttsp_remove(struct cyttsp *ts)
> {
> - free_irq(ts->irq, ts);
> - input_unregister_device(ts->input);
> if (ts->pdata->exit)
> ts->pdata->exit();
> - kfree(ts);
This is not quite correct as it changes the operations order... Given
that it is going to be removed in the next patch I guess it is OK, but
ideally you can add a custom devm action to shut off the chip.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2016-01-21 19:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 19:21 [PATCH v4 0/4] Add device tree support to the cyttsp driver Oreste Salerno
2016-01-21 19:21 ` [PATCH v4 1/4] Input: cyttsp - use devres managed resource allocations Oreste Salerno
2016-01-21 19:29 ` Dmitry Torokhov [this message]
2016-01-21 20:22 ` Oreste Salerno
2016-01-21 21:32 ` Dmitry Torokhov
2016-01-21 19:21 ` [PATCH v4 2/4] Input: cyttsp - check return value of input_mt_init_slots Oreste Salerno
2016-01-21 19:21 ` [PATCH v4 3/4] Input: cyttsp - switch to using device properties Oreste Salerno
2016-01-21 19:25 ` Oreste Salerno
2016-01-21 19:35 ` Dmitry Torokhov
2016-01-21 20:44 ` Oreste Salerno
2016-01-21 21:33 ` Dmitry Torokhov
2016-01-21 19:21 ` [PATCH v4 4/4] Input: cyttsp - perform hard reset of the chip during probe Oreste Salerno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160121192924.GB39970@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=fery@cypress.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=oreste.salerno@tomtom.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox