From: Lee Jones <lee.jones@linaro.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
linus.walleij@linaro.org, gnurou@gmail.com, broonie@kernel.org,
a.zummo@towertech.it, alexandre.belloni@free-electrons.com,
lgirdwood@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
rtc-linux@googlegroups.com, swarren@nvidia.com,
treding@nvidia.com, vreddytalla@nvidia.com,
Chaitanya Bandi <bandik@nvidia.com>,
Mallikarjun Kasoju <mkasoju@nvidia.com>
Subject: Re: [PATCH V4 2/5] mfd: max77620: add core driver for MAX77620/MAX20024
Date: Mon, 25 Jan 2016 11:29:36 +0000 [thread overview]
Message-ID: <20160125112936.GB3368@x1> (raw)
In-Reply-To: <56A214EB.30905@nvidia.com>
On Fri, 22 Jan 2016, Laxman Dewangan wrote:
> Thanks Krzysztof for review.
>
> Hi Lee,
> Are you taking the patches from your tree? Or will go in individual
> subsystem?
I can take the set if there are build dependencies. If there aren't,
then they should be routed via their respective subsystem trees.
> On Wednesday 20 January 2016 10:52 AM, Krzysztof Kozlowski wrote:
> >On 19.01.2016 19:19, Laxman Dewangan wrote:
> >>MAX77620/MAX20024 are Power Management IC from the MAXIM.
> >>It supports RTC, multiple GPIOs, multiple DCDC and LDOs,
> >>watchdog, clock etc.
> >>
> >>Add MFD drier to provides common support for accessing the
> >>device; additional drivers is developed on respected subsystem
> >>in order to use the functionality of the device.
> >>
> >>Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
> >>Signed-off-by: Chaitanya Bandi <bandik@nvidia.com>
> >>Signed-off-by: Mallikarjun Kasoju <mkasoju@nvidia.com>
> >>---
> >>Changes from V1:
> >>- Code cleanups per review from V1.
> >>- Move register acccess APIs from header to c file.
> >>- Remove some of non required variable, remove duplication in error message
> >> and simplify some of function implementation.
> >>- Register RTC driver such that it can get the regmap handle form parent device
> >>
> >>Changes from V2:
> >>- Run coccicheck and checkpatch in strict mode for the alignment.
> >>- Drop RTC driver and its i2c client registration.
> >>
> >>Changes from V3:
> >>- Change all sys initcall to module driver.
> >>- change the max77620_read argument to unisgned int from u8.
> >>
> >> drivers/mfd/Kconfig | 15 +
> >> drivers/mfd/Makefile | 1 +
> >> drivers/mfd/max77620.c | 871 +++++++++++++++++++++++++++++++++++++++++++
> >> include/linux/mfd/max77620.h | 404 ++++++++++++++++++++
> >> 4 files changed, 1291 insertions(+)
> >> create mode 100644 drivers/mfd/max77620.c
> >> create mode 100644 include/linux/mfd/max77620.h
> >>
> >
> >Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >
> >Best regards,
> >Krzysztof
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-01-25 11:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 10:19 [PATCH V4 0/5] Add support for MAXIM MAX77620/MAX20024 PMIC Laxman Dewangan
2016-01-19 10:19 ` [PATCH V4 1/5] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024 Laxman Dewangan
2016-01-25 11:56 ` Lee Jones
2016-01-25 15:08 ` Laxman Dewangan
2016-01-26 14:58 ` Lee Jones
2016-01-26 16:24 ` Laxman Dewangan
2016-01-27 7:24 ` Lee Jones
2016-01-19 10:19 ` [PATCH V4 2/5] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan
2016-01-20 5:22 ` Krzysztof Kozlowski
2016-01-22 11:39 ` Laxman Dewangan
2016-01-25 11:29 ` Lee Jones [this message]
2016-01-25 11:20 ` Laxman Dewangan
2016-01-19 10:19 ` [PATCH V4 3/5] pinctrl: max77620: add pincontrol " Laxman Dewangan
2016-01-28 10:04 ` Linus Walleij
2016-01-28 10:13 ` Laxman Dewangan
2016-01-19 10:19 ` [PATCH V4 4/5] gpio: max77620: add gpio " Laxman Dewangan
2016-01-28 10:05 ` Linus Walleij
2016-01-19 10:19 ` [PATCH V4 5/5] regulator: max77620: add regulator driver for max77620/max20024 Laxman Dewangan
2016-01-20 5:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160125112936.GB3368@x1 \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=bandik@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=k.kozlowski@samsung.com \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mkasoju@nvidia.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=swarren@nvidia.com \
--cc=treding@nvidia.com \
--cc=vreddytalla@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox