* [PATCH] include/linux/list_bl.h: Use bool instead of int for boolean functions @ 2016-01-24 20:58 chengang 2016-01-28 7:22 ` Heiko Carstens 0 siblings, 1 reply; 3+ messages in thread From: chengang @ 2016-01-24 20:58 UTC (permalink / raw) To: akpm, dhowells; +Cc: viro, linux-kernel, paulmck, josh, Chen Gang, Chen Gang From: Chen Gang <chengang@emindsoft.com.cn> hlist_bl_unhashed() and hlist_bl_empty() are all boolean functions, so return bool instead of int. Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> --- include/linux/list_bl.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/list_bl.h b/include/linux/list_bl.h index ee7229a..cb48330 100644 --- a/include/linux/list_bl.h +++ b/include/linux/list_bl.h @@ -48,7 +48,7 @@ static inline void INIT_HLIST_BL_NODE(struct hlist_bl_node *h) #define hlist_bl_entry(ptr, type, member) container_of(ptr,type,member) -static inline int hlist_bl_unhashed(const struct hlist_bl_node *h) +static inline bool hlist_bl_unhashed(const struct hlist_bl_node *h) { return !h->pprev; } @@ -68,7 +68,7 @@ static inline void hlist_bl_set_first(struct hlist_bl_head *h, h->first = (struct hlist_bl_node *)((unsigned long)n | LIST_BL_LOCKMASK); } -static inline int hlist_bl_empty(const struct hlist_bl_head *h) +static inline bool hlist_bl_empty(const struct hlist_bl_head *h) { return !((unsigned long)READ_ONCE(h->first) & ~LIST_BL_LOCKMASK); } -- 1.9.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] include/linux/list_bl.h: Use bool instead of int for boolean functions 2016-01-24 20:58 [PATCH] include/linux/list_bl.h: Use bool instead of int for boolean functions chengang @ 2016-01-28 7:22 ` Heiko Carstens 2016-01-28 15:24 ` Chen Gang 0 siblings, 1 reply; 3+ messages in thread From: Heiko Carstens @ 2016-01-28 7:22 UTC (permalink / raw) To: chengang; +Cc: akpm, dhowells, viro, linux-kernel, paulmck, josh, Chen Gang On Mon, Jan 25, 2016 at 04:58:18AM +0800, chengang@emindsoft.com.cn wrote: > From: Chen Gang <chengang@emindsoft.com.cn> > > hlist_bl_unhashed() and hlist_bl_empty() are all boolean functions, so > return bool instead of int. > > Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> > --- > include/linux/list_bl.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/list_bl.h b/include/linux/list_bl.h > index ee7229a..cb48330 100644 > --- a/include/linux/list_bl.h > +++ b/include/linux/list_bl.h > @@ -48,7 +48,7 @@ static inline void INIT_HLIST_BL_NODE(struct hlist_bl_node *h) > > #define hlist_bl_entry(ptr, type, member) container_of(ptr,type,member) > > -static inline int hlist_bl_unhashed(const struct hlist_bl_node *h) > +static inline bool hlist_bl_unhashed(const struct hlist_bl_node *h) > { > return !h->pprev; > } > @@ -68,7 +68,7 @@ static inline void hlist_bl_set_first(struct hlist_bl_head *h, > h->first = (struct hlist_bl_node *)((unsigned long)n | LIST_BL_LOCKMASK); > } > > -static inline int hlist_bl_empty(const struct hlist_bl_head *h) > +static inline bool hlist_bl_empty(const struct hlist_bl_head *h) > { > return !((unsigned long)READ_ONCE(h->first) & ~LIST_BL_LOCKMASK); Sorry for my ignorance, but what's the point of doing conversions like this? It has zero impact on code generation. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] include/linux/list_bl.h: Use bool instead of int for boolean functions 2016-01-28 7:22 ` Heiko Carstens @ 2016-01-28 15:24 ` Chen Gang 0 siblings, 0 replies; 3+ messages in thread From: Chen Gang @ 2016-01-28 15:24 UTC (permalink / raw) To: Heiko Carstens Cc: akpm, dhowells, viro, linux-kernel, paulmck, josh, Chen Gang On 1/28/16 15:22, Heiko Carstens wrote: > On Mon, Jan 25, 2016 at 04:58:18AM +0800, chengang@emindsoft.com.cn wrote: >> From: Chen Gang <chengang@emindsoft.com.cn> >> >> hlist_bl_unhashed() and hlist_bl_empty() are all boolean functions, so >> return bool instead of int. >> >> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com> >> --- >> include/linux/list_bl.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/list_bl.h b/include/linux/list_bl.h >> index ee7229a..cb48330 100644 >> --- a/include/linux/list_bl.h >> +++ b/include/linux/list_bl.h >> @@ -48,7 +48,7 @@ static inline void INIT_HLIST_BL_NODE(struct hlist_bl_node *h) >> >> #define hlist_bl_entry(ptr, type, member) container_of(ptr,type,member) >> >> -static inline int hlist_bl_unhashed(const struct hlist_bl_node *h) >> +static inline bool hlist_bl_unhashed(const struct hlist_bl_node *h) >> { >> return !h->pprev; >> } >> @@ -68,7 +68,7 @@ static inline void hlist_bl_set_first(struct hlist_bl_head *h, >> h->first = (struct hlist_bl_node *)((unsigned long)n | LIST_BL_LOCKMASK); >> } >> >> -static inline int hlist_bl_empty(const struct hlist_bl_head *h) >> +static inline bool hlist_bl_empty(const struct hlist_bl_head *h) >> { >> return !((unsigned long)READ_ONCE(h->first) & ~LIST_BL_LOCKMASK); > > Sorry for my ignorance, but what's the point of doing conversions like > this? It has zero impact on code generation. > For me, in our case, the 2 functions really generate boolean value, and they are really used as boolean functions, so returning boolean value will let the code a little simpler and a little clearer. Thanks. -- Chen Gang (陈刚) Open, share, and attitude like air, water, and life which God blessed ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-28 15:21 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-01-24 20:58 [PATCH] include/linux/list_bl.h: Use bool instead of int for boolean functions chengang 2016-01-28 7:22 ` Heiko Carstens 2016-01-28 15:24 ` Chen Gang
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox