From: Lee Jones <lee.jones@linaro.org>
To: chenfeng <puck.chen@hisilicon.com>
Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com,
broonie@kernel.org, yudongbin@hisilicon.com,
saberlily.xia@hisilicon.com, suzhuangluan@hisilicon.com,
kong.kongxinwei@hisilicon.com, xuyiping@hisilicon.com,
z.liuxinliang@hisilicon.com, puck.chenfeng@gmail.com,
weidong2@hisilicon.com, w.f@huawei.com, qijiwen@hisilicon.com,
peter.panshilin@hisilicon.com, dan.zhao@hisilicon.com,
linuxarm@huawei.com, liguozhu@hisilicon.com
Subject: Re: [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver
Date: Thu, 28 Jan 2016 11:30:00 +0000 [thread overview]
Message-ID: <20160128113000.GO3368@x1> (raw)
In-Reply-To: <56A9E405.1080808@hisilicon.com>
On Thu, 28 Jan 2016, chenfeng wrote:
> Hi Lee,
>
> Thanks for your review!
> There is one things need your confirm.
> Please help to see it below.
>
> On 2016/1/25 22:22, Lee Jones wrote:
> > On Mon, 11 Jan 2016, Chen Feng wrote:
> >
> >> Add pmic mfd driver to support hisilicon hi665x.
> [..]
>
> >
> >> +static const struct mfd_cell hi655x_pmic_devs[] = {
> >> + { .name = "hi655x-regulator", },
> >> +};
> >
> > What other devices are there?
> >
>
> Current the MFD PMIC driver only has regulator enable.
>
> The RTC & Power-key are not in these patch sets.
>
> They will be added later.
>
> Will this be accepted?
Yes.
> >> +static const struct regmap_irq hi655x_irqs[] = {
> >> + { .reg_offset = 0, .mask = OTMP_D1R_INT },
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-01-28 11:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-11 12:20 [PATCH v5 0/5] Add Support for Hi6220 PMIC Hi6553 MFD Core Chen Feng
2016-01-11 12:20 ` [PATCH v5 1/5] doc: bindings: Add document for mfd hi665x PMIC Chen Feng
2016-01-25 12:53 ` Lee Jones
2016-01-26 6:26 ` chenfeng
2016-01-11 12:20 ` [PATCH v5 2/5] doc: bindings: Document for hi655x regulator driver Chen Feng
2016-01-11 18:17 ` Mark Brown
2016-01-12 2:07 ` chenfeng
2016-01-11 12:20 ` [PATCH v5 3/5] mfd: hi655x: Add hi665x pmic driver Chen Feng
2016-01-25 14:22 ` Lee Jones
2016-01-26 6:32 ` chenfeng
2016-01-28 9:48 ` chenfeng
2016-01-28 11:30 ` Lee Jones [this message]
2016-01-11 12:20 ` [PATCH v5 4/5] regulator: add regulator driver of hi655x pmic Chen Feng
2016-01-11 18:24 ` Mark Brown
2016-01-12 2:18 ` chenfeng
2016-01-15 18:07 ` Mark Brown
2016-01-18 8:26 ` chenfeng
2016-01-11 12:20 ` [PATCH v5 5/5] hisilicon/dts: Add hi655x pmic dts node Chen Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160128113000.GO3368@x1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=dan.zhao@hisilicon.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=lgirdwood@gmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=peter.panshilin@hisilicon.com \
--cc=puck.chen@hisilicon.com \
--cc=puck.chenfeng@gmail.com \
--cc=qijiwen@hisilicon.com \
--cc=saberlily.xia@hisilicon.com \
--cc=suzhuangluan@hisilicon.com \
--cc=w.f@huawei.com \
--cc=weidong2@hisilicon.com \
--cc=xuyiping@hisilicon.com \
--cc=yudongbin@hisilicon.com \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox