From: Rob Herring <robh@kernel.org>
To: dinguyen@opensource.altera.com
Cc: ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
mark.rutland@arm.com, pawel.moll@arm.com, dinh.linux@gmail.com,
andrew@lunn.ch, davem@davemloft.net, f.fainelli@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Doc: Micrel-ksz90x1.txt: Update the Micrel phy documentation for ksz9031
Date: Thu, 28 Jan 2016 21:33:06 -0600 [thread overview]
Message-ID: <20160129033306.GA18787@rob-hp-laptop> (raw)
In-Reply-To: <1453999767-26298-1-git-send-email-dinguyen@opensource.altera.com>
On Thu, Jan 28, 2016 at 10:49:27AM -0600, dinguyen@opensource.altera.com wrote:
> From: Dinh Nguyen <dinguyen@opensource.altera.com>
>
> Update the Micrel phy documentation for the KSZ9031 PHY to represent how
> the actual values are calculated from the code.
>
> Signed-off-by: Dinh Nguyen <dinguyen@opensource.altera.com>
> ---
> .../devicetree/bindings/net/micrel-ksz90x1.txt | 73 ++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt b/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
> index f9c32ad..9535b2b 100644
> --- a/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
> +++ b/Documentation/devicetree/bindings/net/micrel-ksz90x1.txt
> @@ -36,6 +36,71 @@ KSZ9031:
> value is 0, and the maximum is property-dependent. The increment
> step is 60ps.
>
> + The KSZ9031 hardware supports a range of skew values from negative to
> + positive, where the specific range is property dependent. All values
> + specified in the devicetree are offset by the minimum value so they
> + can be represented as positive integers in the devicetree since it's
> + difficult to represent a negative number in the devictree.
I don't think that is true anymore. dtc should allow negative numbers
AIUI. That would be much better here.
Rob
prev parent reply other threads:[~2016-01-29 3:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 16:49 [PATCH] Doc: Micrel-ksz90x1.txt: Update the Micrel phy documentation for ksz9031 dinguyen
2016-01-29 3:33 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160129033306.GA18787@rob-hp-laptop \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@opensource.altera.com \
--cc=dinh.linux@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox