From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: Chen Yucong <slaoub@gmail.com>,
hpa@zytor.com, tony.luck@intel.com, x86@kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] mcheck/therm_throt: Replace printk(KERN_XX...) with pr_xx(...)
Date: Mon, 1 Feb 2016 10:38:09 +0100 [thread overview]
Message-ID: <20160201093809.GA6438@pd.tnic> (raw)
In-Reply-To: <20160201082412.GA15735@gmail.com>
On Mon, Feb 01, 2016 at 09:24:12AM +0100, Ingo Molnar wrote:
> > So there are 37,000+ printk() calls in the kernel and 900+ ones in arch/x86/
> > alone! Plus even after this patch there's 20 more printk()s left in
> > arch/x86/kernel/cpu/mcheck/...
> >
> > We don't want to create a churn of 10,000+ commits to convert them to pr_*()
> > facilities...
> >
> > So we don't apply such 'conversion' patches unless it's done for a whole subsystem
> > and done as part of a larger work with good reason, or if it's done as part of
> > completely new facilities/drivers - and is done consistently.
> >
> > Even then it's dubious to convert: people keep re-adding printk()s (which is a
> > perfectly fine facility), which generates never ending churn ...
Amen to that!
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
prev parent reply other threads:[~2016-02-01 9:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1454312473-2685-1-git-send-email-slaoub@gmail.com>
[not found] ` <20160201081951.GA14977@gmail.com>
2016-02-01 8:24 ` [PATCH] mcheck/therm_throt: Replace printk(KERN_XX...) with pr_xx(...) Ingo Molnar
2016-02-01 9:38 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160201093809.GA6438@pd.tnic \
--to=bp@alien8.de \
--cc=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=slaoub@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox