From: Borislav Petkov <bp@suse.de>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, Andy Lutomirski <luto@kernel.org>,
Alexander Popov <alpopov@ptsecurity.com>,
Denys Vlasenko <dvlasenk@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] x86/head64: no need to define early_idt_ripmsg only if CONFIG_KALLSYMS=n
Date: Thu, 18 Feb 2016 14:36:08 +0100 [thread overview]
Message-ID: <20160218133608.GC28860@pd.tnic> (raw)
In-Reply-To: <1455782295-3877-1-git-send-email-kuleshovmail@gmail.com>
On Thu, Feb 18, 2016 at 01:58:15PM +0600, Alexander Kuleshov wrote:
> We have definition of the early_idt_ripmsg which represents string header
> for the output of the kernel symbols during early exception. But the
> header with kernel symbols will be printed in a case if the CONFIG_KALLSYMS=y.
And this is a problem because... ?
Also, try to search how many distros and configs enable KALLSYMS. That
might clear some uncertainties when deciding to add one more ifdef to an
already hard to read code.
--
Regards/Gruss,
Boris.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
prev parent reply other threads:[~2016-02-18 13:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 7:58 [PATCH v2] x86/head64: no need to define early_idt_ripmsg only if CONFIG_KALLSYMS=n Alexander Kuleshov
2016-02-18 13:36 ` Borislav Petkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160218133608.GC28860@pd.tnic \
--to=bp@suse.de \
--cc=alpopov@ptsecurity.com \
--cc=dvlasenk@redhat.com \
--cc=hpa@zytor.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox