From: Mark Brown <broonie@kernel.org>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
lgirdwood@gmail.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] regulator: core: Add support for active-discharge configuration
Date: Wed, 2 Mar 2016 12:13:38 +0900 [thread overview]
Message-ID: <20160302031338.GU18327@sirena.org.uk> (raw)
In-Reply-To: <56D64984.8080405@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
On Wed, Mar 02, 2016 at 07:31:40AM +0530, Laxman Dewangan wrote:
> Yaah, I agree.
> I had other option to use 0 as default, 1 as disable and 2 as enable. but
> generally for disable, we use 0 and for enable 1 and that's why I went to
> -1,0,1 approach.
> Will it be fine to have this as
> 0: Default i..e do not change.
> 1: disable.
> 2: Enable.
I'd suggest defining an enum here with default explicitly set to 0 but
yes.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-02 3:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 12:38 [PATCH 0/4] regulator: Add support for configuration of active-discharge Laxman Dewangan
2016-03-01 12:38 ` [PATCH 1/4] regulator: DT: Add DT property for active-discharge configuration Laxman Dewangan
2016-03-01 12:38 ` [PATCH 2/4] regulator: core: Add support " Laxman Dewangan
2016-03-02 1:44 ` Mark Brown
2016-03-02 2:01 ` Laxman Dewangan
2016-03-02 3:13 ` Mark Brown [this message]
2016-03-01 12:38 ` [PATCH 3/4] regulator: helper: Add helper to configure active-discharge using regmap Laxman Dewangan
2016-03-01 12:38 ` [PATCH 4/4] regulator: max77620: Add support to configure active-discharge Laxman Dewangan
-- strict thread matches above, loose matches on Subject: below --
2016-03-02 6:56 [PATCH V2 0/4] regulator: Add support for configuration of active-discharge Laxman Dewangan
2016-03-02 6:56 ` [PATCH 2/4] regulator: core: Add support for active-discharge configuration Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302031338.GU18327@sirena.org.uk \
--to=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ldewangan@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox