From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Juergen Borleis <jbe@pengutronix.de>
Cc: kbuild test robot <fengguang.wu@intel.com>,
rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org
Subject: Re: [abelloni:rtc-testing 55/55] drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063'
Date: Wed, 2 Mar 2016 11:26:34 +0100 [thread overview]
Message-ID: <20160302102634.GN23985@piout.net> (raw)
In-Reply-To: <201603021044.29444.jbe@pengutronix.de>
Hi,
On 02/03/2016 at 10:44:29 +0100, Juergen Borleis wrote :
> Hi Alexandre,
>
> On Tuesday 01 March 2016 23:17:45 kbuild test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git
> > rtc-testing head: 58992ebde059d7faeab4c18bc17713c3b4c31208
> > commit: 58992ebde059d7faeab4c18bc17713c3b4c31208 [55/55] rtc: pcf85063:
> > remove useless century handling config: x86_64-randconfig-x012-201609
> > (attached as .config)
> > reproduce:
> > git checkout 58992ebde059d7faeab4c18bc17713c3b4c31208
> > # save the attached .config to linux build tree
> > make ARCH=x86_64
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/rtc/rtc-pcf85063.c: In function 'pcf85063_get_datetime':
> > >> drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063'
> > >> [-Wunused-variable]
> >
> > struct pcf85063 *pcf85063 = i2c_get_clientdata(client);
> > ^
>
> Due to your removement of the useless century handling the last user of 'struct
> pcf85063' is gone. Seems we can remove this struct entirely. What do you
> think?
>
Sure, that was also my reasoning when fixing that warning. I've sent
follow up patches.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-03-02 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201603020626.sgWd959D%fengguang.wu@intel.com>
2016-03-02 9:44 ` [abelloni:rtc-testing 55/55] drivers/rtc/rtc-pcf85063.c:72:19: warning: unused variable 'pcf85063' Juergen Borleis
2016-03-02 10:26 ` Alexandre Belloni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160302102634.GN23985@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=fengguang.wu@intel.com \
--cc=jbe@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox