From: Greg KH <gregkh@linuxfoundation.org>
To: Thimo Braker <thibmorozier@gmail.com>
Cc: devel@driverdev.osuosl.org, arve@android.com,
linux-kernel@vger.kernel.org, riandrews@android.com,
sumit.semwal@linaro.org
Subject: Re: [PATCH 1/2] Staging: android: ion: fixes use of typedef
Date: Sun, 8 May 2016 04:46:27 +0200 [thread overview]
Message-ID: <20160508024627.GA13955@kroah.com> (raw)
In-Reply-To: <1462652523-25037-1-git-send-email-thibmorozier@gmail.com>
On Sat, May 07, 2016 at 03:22:03PM -0500, Thimo Braker wrote:
> Fixes a checkpatch.pl warning about 'do not add new typedefs'
>
> Signed-off-by: Thimo Braker <thibmorozier@gmail.com>
> ---
> drivers/staging/android/uapi/ion.h | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/android/uapi/ion.h b/drivers/staging/android/uapi/ion.h
> index 0a8e40f..77a46f0 100644
> --- a/drivers/staging/android/uapi/ion.h
> +++ b/drivers/staging/android/uapi/ion.h
> @@ -20,8 +20,6 @@
> #include <linux/ioctl.h>
> #include <linux/types.h>
>
> -typedef int ion_user_handle_t;
> -
You just broke userspace :(
Sorry, you can't do this, be careful when touching files that cross the
user/kernel boundry (hint, they have uapi in the path), you have to know
exactly what you are doing when you do that.
thanks,
greg k-h
next prev parent reply other threads:[~2016-05-08 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-07 20:22 [PATCH 1/2] Staging: android: ion: fixes use of typedef Thimo Braker
2016-05-08 2:46 ` Greg KH [this message]
2016-05-08 10:43 ` Thimo Braker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160508024627.GA13955@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
--cc=thibmorozier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox