* [patch] phy: bcm-ns-usb2: checking the wrong variable
@ 2016-05-10 8:01 Dan Carpenter
2016-05-10 8:05 ` Rafał Miłecki
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2016-05-10 8:01 UTC (permalink / raw)
To: Kishon Vijay Abraham I, Rafał Miłecki
Cc: linux-kernel, kernel-janitors
We intended to test "usb2->phy" here instead of "dev".
Fixes: d3feb4067335 ('phy: bcm-ns-usb2: new driver for USB 2.0 PHY on Northstar')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/phy/phy-bcm-ns-usb2.c b/drivers/phy/phy-bcm-ns-usb2.c
index 95ab6b2..58dff80 100644
--- a/drivers/phy/phy-bcm-ns-usb2.c
+++ b/drivers/phy/phy-bcm-ns-usb2.c
@@ -109,8 +109,8 @@ static int bcm_ns_usb2_probe(struct platform_device *pdev)
}
usb2->phy = devm_phy_create(dev, NULL, &ops);
- if (IS_ERR(dev))
- return PTR_ERR(dev);
+ if (IS_ERR(usb2->phy))
+ return PTR_ERR(usb2->phy);
phy_set_drvdata(usb2->phy, usb2);
platform_set_drvdata(pdev, usb2);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] phy: bcm-ns-usb2: checking the wrong variable
2016-05-10 8:01 [patch] phy: bcm-ns-usb2: checking the wrong variable Dan Carpenter
@ 2016-05-10 8:05 ` Rafał Miłecki
0 siblings, 0 replies; 2+ messages in thread
From: Rafał Miłecki @ 2016-05-10 8:05 UTC (permalink / raw)
To: Dan Carpenter
Cc: Kishon Vijay Abraham I, Linux Kernel Mailing List,
kernel-janitors
On 10 May 2016 at 10:01, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We intended to test "usb2->phy" here instead of "dev".
>
> Fixes: d3feb4067335 ('phy: bcm-ns-usb2: new driver for USB 2.0 PHY on Northstar')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-10 8:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-10 8:01 [patch] phy: bcm-ns-usb2: checking the wrong variable Dan Carpenter
2016-05-10 8:05 ` Rafał Miłecki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox