From: Ralf Baechle <ralf@linux-mips.org>
To: Paul Burton <paul.burton@imgtec.com>
Cc: linux-mips@linux-mips.org, "Maciej W. Rozycki" <macro@imgtec.com>,
linux-kernel@vger.kernel.org,
James Hogan <james.hogan@imgtec.com>,
Markos Chandras <markos.chandras@imgtec.com>
Subject: Re: [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation
Date: Tue, 10 May 2016 10:09:40 +0200 [thread overview]
Message-ID: <20160510080940.GD16402@linux-mips.org> (raw)
In-Reply-To: <1461243895-30371-2-git-send-email-paul.burton@imgtec.com>
On Thu, Apr 21, 2016 at 02:04:45PM +0100, Paul Burton wrote:
> The conditions for branching when emulating the BC1EQZ & BC1NEZ
> instructions were backwards, leading to each of those instructions being
> treated as the other. Fix this by reversing the conditions, and clear up
> the code a little for readability & checkpatch.
>
> Fixes: c909ca718e8f ("MIPS: math-emu: Emulate missing BC1{EQ,NE}Z instructions")
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> Reviewed-by: James Hogan <james.hogan@imgtec.com>
Patch ok - but you may want to take Markos off the cc list. Or iff he's
still interested, is there any new address for him to use instead?
Ralf
next prev parent reply other threads:[~2016-05-10 8:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 13:04 [PATCH 00/11] FP emulation fixes Paul Burton
2016-04-21 13:04 ` [PATCH 01/11] MIPS: math-emu: Fix BC1{EQ,NE}Z emulation Paul Burton
2016-05-10 8:09 ` Ralf Baechle [this message]
2016-05-10 8:43 ` Paul Burton
2016-05-10 8:54 ` Ralf Baechle
2016-04-21 13:04 ` [PATCH 02/11] MIPS: Fix BC1{EQ,NE}Z return offset calculation Paul Burton
2016-04-21 13:04 ` [PATCH 03/11] MIPS: inst: Declare fsel_op for sel.fmt instruction Paul Burton
2016-04-21 13:04 ` [PATCH 04/11] MIPS: math-emu: Emulate MIPSr6 " Paul Burton
2016-04-21 13:04 ` [PATCH 05/11] MIPS: math-emu: Unify ieee754sp_m{add,sub}f Paul Burton
2016-04-21 13:04 ` [PATCH 06/11] MIPS: math-emu: Unify ieee754dp_m{add,sub}f Paul Burton
2016-04-21 13:04 ` [PATCH 07/11] MIPS: math-emu: Add z argument macros Paul Burton
2016-04-21 13:04 ` [PATCH 08/11] MIPS: math-emu: Fix bit-width in ieee754dp_{mul,maddf,msubf} comments Paul Burton
2016-04-21 13:04 ` [PATCH 09/11] MIPS: math-emu: Fix code indentation Paul Burton
2016-04-21 13:04 ` [PATCH 10/11] MIPS: math-emu: Fix m{add,sub}.s shifts Paul Burton
2016-04-21 13:04 ` [PATCH 11/11] MIPS: math-emu: Fix jalr emulation when rd == $0 Paul Burton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160510080940.GD16402@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=james.hogan@imgtec.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=macro@imgtec.com \
--cc=markos.chandras@imgtec.com \
--cc=paul.burton@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox