From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] f2fs: support in batch multi blocks preallocation
Date: Tue, 10 May 2016 19:32:24 -0700 [thread overview]
Message-ID: <20160511023224.GA15972@jaegeuk.gateway> (raw)
In-Reply-To: <705bb492-b510-462e-fef3-d2f66dbb871f@huawei.com>
On Wed, May 11, 2016 at 10:22:05AM +0800, Chao Yu wrote:
> On 2016/5/11 5:41, Jaegeuk Kim wrote:
> > +
> > + f2fs_wait_on_page_writeback(dn->node_page, NODE, true);
> > +
> > + for (; count > 0; dn->ofs_in_node++) {
> > + block_t blkaddr =
> > + datablock_addr(dn->node_page, dn->ofs_in_node);
> > + if (blkaddr == NULL_ADDR) {
> > + dn->data_blkaddr = NEW_ADDR;
> > + __set_data_blkaddr(dn);
> > + count--;
> > + }
> > + }
>
> Should let ofs_in_node increase to offset where blkaddr = NULL_ADDR in
> ENOSPC case or increase to end_offset in normal case, right?
hehe, I could get some errors on this patch. :)
Finally, I've made a patch which passes xfstests and fsstress.
Could you find the latest ones?
http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs.git/log/?h=dev-test
>
> Thanks,
next prev parent reply other threads:[~2016-05-11 2:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 11:56 [PATCH 1/6] f2fs: support in batch multi blocks preallocation Chao Yu
2016-05-09 11:56 ` [PATCH 2/6] f2fs: support in batch fzero in dnode page Chao Yu
2016-05-09 23:03 ` Jaegeuk Kim
2016-05-09 11:56 ` [PATCH 3/6] f2fs: use mnt_{want,drop}_write_file in ioctl Chao Yu
2016-05-09 11:56 ` [PATCH 4/6] f2fs: make atomic/volatile operation exclusive Chao Yu
2016-05-09 11:56 ` [PATCH 5/6] f2fs: enable inline_dentry by default Chao Yu
2016-05-09 23:04 ` Jaegeuk Kim
2016-08-22 1:49 ` Chao Yu
2016-08-23 16:57 ` Jaegeuk Kim
2016-08-25 9:23 ` Chao Yu
2016-05-09 11:56 ` [PATCH 6/6] f2fs: add noinline_dentry mount option Chao Yu
2016-05-09 23:00 ` [PATCH 1/6] f2fs: support in batch multi blocks preallocation Jaegeuk Kim
2016-05-10 12:55 ` Chao Yu
2016-05-10 21:41 ` Jaegeuk Kim
2016-05-11 2:22 ` Chao Yu
2016-05-11 2:32 ` Jaegeuk Kim [this message]
2016-05-11 3:00 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511023224.GA15972@jaegeuk.gateway \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox