From: Mark Brown <broonie@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] ASoC: MAX9860: new driver
Date: Wed, 11 May 2016 21:50:52 +0100 [thread overview]
Message-ID: <20160511205052.GU6261@sirena.org.uk> (raw)
In-Reply-To: <65bdbaea-fe4e-bbd5-335d-a8d594936cbe@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 1042 bytes --]
On Wed, May 11, 2016 at 10:12:56PM +0200, Peter Rosin wrote:
> On 2016-05-11 17:09, Mark Brown wrote:
> > On Tue, May 10, 2016 at 05:06:37PM +0200, Peter Rosin wrote:
> >> This driver does not support sidetone since the DVST register field is
> >> backwards with the mute near the maximum level instead of the minimum.
> > Why would that be an issue? We support volume controls in either
> > direction.
> I asked about this last week (or so), maybe that question explains the
> situation?
> http://www.spinics.net/lists/alsa-devel/msg49675.html
If you don't CC maintainers the chances are your mails just won't get
seen...
You should change DAPM so that it understands what your control is
doing, possibly by using custom accessors though it seems like something
in the vein of the invert flag ought to do the trick. You don't want to
actually use the invert flag since increasing values do mean increasing
volume but something along those lines. Possibly doing it by parsing
the TLV for a mute value at probe time might make sense?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-11 20:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 15:06 [PATCH] ASoC: MAX9860: new driver Peter Rosin
2016-05-11 15:09 ` Mark Brown
2016-05-11 20:12 ` Peter Rosin
2016-05-11 20:50 ` Mark Brown [this message]
2016-05-12 7:54 ` Peter Rosin
2016-05-12 11:04 ` Mark Brown
2016-05-11 15:29 ` Mark Brown
2016-05-11 20:28 ` Peter Rosin
2016-05-11 20:53 ` Mark Brown
2016-05-12 8:24 ` Peter Rosin
2016-05-12 10:53 ` Mark Brown
2016-05-14 14:25 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511205052.GU6261@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=peda@axentia.se \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox