From: Borislav Petkov <bp@alien8.de>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: dougthompson@xmission.com, mchehab@osg.samsung.com,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] edac:Fix kernel panic regression in edac_mc_reset_delay_period due to missing mode operation check
Date: Fri, 20 May 2016 10:42:44 +0200 [thread overview]
Message-ID: <20160520084244.GA501@pd.tnic> (raw)
In-Reply-To: <1463697958-13406-1-git-send-email-xerofoify@gmail.com>
On Thu, May 19, 2016 at 06:45:58PM -0400, Nicholas Krause wrote:
> This fixes a kernel panic regression in the function,
> edac_mc_reset_delay_period as show by this kernel panic
> trace:
...
> drivers/edac/edac_mc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
> index 6aa256b0..c3ee3ad 100644
> --- a/drivers/edac/edac_mc.c
> +++ b/drivers/edac/edac_mc.c
> @@ -565,7 +565,8 @@ void edac_mc_reset_delay_period(unsigned long value)
> list_for_each(item, &mc_devices) {
> mci = list_entry(item, struct mem_ctl_info, link);
>
> - edac_mod_work(&mci->work, value);
> + if (mci->op_state == OP_RUNNING_POLL)
> + edac_mod_work(&mci->work, value);
> }
> mutex_unlock(&mem_ctls_mutex);
> }
> --
Looks good to me. I'll apply it after the merge window is over.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
parent reply other threads:[~2016-05-20 8:43 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1463697958-13406-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160520084244.GA501@pd.tnic \
--to=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox