From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tobin C Harding <me@tobin.cc>
Cc: patrik.r.jakobsson@gmail.com, David Airlie <airlied@linux.ie>,
Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
"John L. Hammond" <john.hammond@intel.com>,
Dmitry Eremin <dmitry.eremin@intel.com>,
Frank Zago <fzago@cray.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Al Viro <viro@zeniv.linux.org.uk>,
James Nunez <james.a.nunez@intel.com>,
Abdul Hussain <habdul@visteon.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup_user
Date: Sun, 22 May 2016 15:25:38 -0700 [thread overview]
Message-ID: <20160522222538.GA17573@kroah.com> (raw)
In-Reply-To: <1463953771-16942-1-git-send-email-me@tobin.cc>
On Mon, May 23, 2016 at 07:49:29AM +1000, Tobin C Harding wrote:
> kzalloc call followed by copy_to_user can be replaced by call to memdup_user.
>
> Signed-off-by: Tobin C Harding <me@tobin.cc>
Why did you send this twice?
> ---
> drivers/gpu/drm/gma500/gma_display.c | 2 +-
> drivers/staging/lustre/lustre/llite/dir.c | 22 +++++++---------------
> 2 files changed, 8 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/gma_display.c b/drivers/gpu/drm/gma500/gma_display.c
> index 5bf765d..8a1fb25 100644
> --- a/drivers/gpu/drm/gma500/gma_display.c
> +++ b/drivers/gpu/drm/gma500/gma_display.c
> @@ -285,7 +285,7 @@ void gma_crtc_dpms(struct drm_crtc *crtc, int mode)
>
> /* Wait for vblank for the disable to take effect */
> gma_wait_for_vblank(dev);
> -
> +l
What? What does this have to do with lustre?
It's kind of obvious you didn't build this :(
Please be more careful in the future.
greg k-h
next parent reply other threads:[~2016-05-22 22:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1463953771-16942-1-git-send-email-me@tobin.cc>
2016-05-22 22:25 ` Greg Kroah-Hartman [this message]
2016-05-23 0:20 ` [PATCH] staging: lustre: llite: kzalloc/copy_to_user to memdup_user Tobin Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160522222538.GA17573@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Julia.Lawall@lip6.fr \
--cc=airlied@linux.ie \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=dmitry.eremin@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fzago@cray.com \
--cc=habdul@visteon.com \
--cc=james.a.nunez@intel.com \
--cc=john.hammond@intel.com \
--cc=jsimmons@infradead.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=me@tobin.cc \
--cc=oleg.drokin@intel.com \
--cc=patrik.r.jakobsson@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox