From: Tejun Heo <tj@kernel.org>
To: Kenny Yu <kennyyu@fb.com>
Cc: lizefan@huawei.com, hannes@cmpxchg.org, cyphar@cyphar.com,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH v4] cgroup: Add pids controller event when fork fails because of pid limit
Date: Tue, 21 Jun 2016 14:06:29 -0400 [thread overview]
Message-ID: <20160621180629.GN3262@mtj.duckdns.org> (raw)
In-Reply-To: <1466531090-3539070-1-git-send-email-kennyyu@fb.com>
On Tue, Jun 21, 2016 at 10:44:50AM -0700, Kenny Yu wrote:
> This patch adds more visibility into the pids controller when the controller
> rejects a fork request. Whenever fork fails because the limit on the number of
> pids in the cgroup is reached, the controller will log this and also notify the
> newly added cgroups events file. The `max` key in the events file represents
> the number of times fork failed because of the pids controller.
>
> This change also logs only the first time the `max` event counter is
> incremented. This is to provide a hint to the user to understand why fork
> failed, as users are not yet used to seeing fork failures because of the
> pids controller.
>
> Signed-off-by: Kenny Yu <kennyyu@fb.com>
> Acked-by: Johannes Weiner <hannes <at> cmpxchg.org>
Applied to cgroup/for-4.8. Thanks!
--
tejun
prev parent reply other threads:[~2016-06-21 18:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 3:09 [PATCH] cgroup: Add pids controller event when fork fails because of pid limit Kenny Yu
2016-06-21 4:44 ` Johannes Weiner
2016-06-21 16:01 ` [PATCH v2] " Kenny Yu
2016-06-21 16:07 ` Aleksa Sarai
2016-06-21 16:34 ` Tejun Heo
2016-06-21 16:56 ` [PATCH v3] " Kenny Yu
2016-06-21 17:12 ` Tejun Heo
2016-06-21 17:23 ` Kenny Yu
2016-06-21 17:28 ` Tejun Heo
2016-06-21 17:44 ` [PATCH v4] " Kenny Yu
2016-06-21 18:06 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621180629.GN3262@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=cyphar@cyphar.com \
--cc=hannes@cmpxchg.org \
--cc=kennyyu@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox