Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33

Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 531 bytes --]

Hi,

Thanks for working on this.

On Tue, Jun 28, 2016 at 06:13:23PM +0800, Icenowy Zheng wrote:
> This patch adds support for the sun8iw3 thermal sensor on
> Allwinner A23/33 SoCs.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>

The IP is awfully similar to the A31's, which already has a driver
(drivers/input/touchscreen/sun4i-ts.c).

There's no reason to add a new one here.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 955 bytes --]

Hi,

On Tue, Jun 28, 2016 at 09:56:22PM +0800, Icenowy Zheng wrote:
> The reason for a dedicate driver is:
> 1. This IP have only thermal function, so it's not suitable to use a
> driver at drivers/input/touchscreen/.

That's not a problem, and it's being worked on [1].

> 2. Control Register are quite different.

That's not a problem either, there's just a bit that you don't need to
set in the control 1 register, and that's pretty much it. It doesn't
justify a whole new driver.

> 3. This IP uses AUDIO PLL (PLL2) as its clock!

It's listed as the input, but all the rest of the documentation refers
only to 24MHz, which seems to indicate that it's only running on the
oscillator, which would make much more sense.

Thanks,
Maxime

1: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-June/439487.html

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 375 bytes --]

On Wed, Jun 29, 2016 at 09:31:39PM +0800, Icenowy Zheng wrote:
> However, sun8iw3/5 ths is not even a GPADC... It's a specified IP,
> only used as an ADC suitable for temperature sensor.

It doesn't matter. It's the same IP, labelled differently.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [RFC PATCH 1/5] clk: sunxi: Add a driver for the PLL2 on A31/23/33

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

Hi,

On Tue, Jun 28, 2016 at 06:13:21PM +0800, Icenowy Zheng wrote:
> This is based on the PLL2 driver for A10/20.

Thanks for this patch.

However, as you might have seen, we're switching to a new clock code
base, so it would be great if you could use that instead.

http://lists.infradead.org/pipermail/linux-arm-kernel/2016-June/440077.html

While we declared all the clocks for the H3, nothing really mandates
that for the existing platforms we don't introduce a few clocks as
they are needed. That will probably even smoothen the transition.

Thanks,
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]