From: Peter Zijlstra <peterz@infradead.org>
To: Xunlei Pang <xlpang@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Subject: Re: [PATCH] sched/fair: Fix the misuse of cfs_rq in sync_throttle()
Date: Tue, 12 Jul 2016 17:26:40 +0200 [thread overview]
Message-ID: <20160712152640.GW30909@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1468050862-18864-1-git-send-email-xlpang@redhat.com>
On Sat, Jul 09, 2016 at 03:54:22PM +0800, Xunlei Pang wrote:
> +++ b/kernel/sched/fair.c
> @@ -4269,7 +4269,7 @@ static void sync_throttle(struct task_group *tg, int cpu)
> pcfs_rq = tg->parent->cfs_rq[cpu];
>
> cfs_rq->throttle_count = pcfs_rq->throttle_count;
> - pcfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
> + cfs_rq->throttled_clock_task = rq_clock_task(cpu_rq(cpu));
Ah indeed, thanks!
> }
>
> /* conditionally throttle active cfs_rq's from put_prev_entity() */
> --
> 1.8.3.1
>
next prev parent reply other threads:[~2016-07-12 15:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 7:54 [PATCH] sched/fair: Fix the misuse of cfs_rq in sync_throttle() Xunlei Pang
2016-07-09 8:12 ` Konstantin Khlebnikov
2016-07-12 15:26 ` Peter Zijlstra [this message]
2016-08-10 18:00 ` [tip:sched/core] sched/fair: Fix typo " tip-bot for Xunlei Pang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712152640.GW30909@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=xlpang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox