From: Byungchul Park <byungchul.park@lge.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: peterz@infradead.org, mingo@kernel.org,
linux-kernel@vger.kernel.org, walken@google.com
Subject: Re: [PATCH 1/2] x86/dumpstack: Optimize save_stack_trace
Date: Mon, 18 Jul 2016 12:25:10 +0900 [thread overview]
Message-ID: <20160718032510.GO2279@X58A-UD3R> (raw)
In-Reply-To: <20160708144403.GG30200@lerouge>
On Fri, Jul 08, 2016 at 04:44:04PM +0200, Frederic Weisbecker wrote:
> Nice improvement but how about doing that with the return value of
> stacktrace_ops::address() instead?
>
> print_context_stack_bp() uses that for example. This behaviour could
> be extended.
Yes. I will leave the change in print_context_stack_bp() unchanged back.
But frankly speaking, I thought the way to add end_walk improves
its readibility. So I am not sure which way is better. Could you any guys
give me additional opinions about the way to implement? I will follow it.
Thank you,
Byungchul
prev parent reply other threads:[~2016-07-18 3:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 10:27 [PATCH 1/2] x86/dumpstack: Optimize save_stack_trace Byungchul Park
2016-07-04 10:27 ` [PATCH 2/2] x86/dumpstack: Add save_stack_trace_norm() Byungchul Park
2016-07-07 10:17 ` [PATCH 1/2] x86/dumpstack: Optimize save_stack_trace Byungchul Park
2016-07-08 10:08 ` Ingo Molnar
2016-07-08 14:29 ` Josh Poimboeuf
2016-07-08 14:48 ` Ingo Molnar
2016-07-08 15:02 ` Frederic Weisbecker
2016-07-08 15:22 ` Josh Poimboeuf
2016-07-18 3:14 ` Byungchul Park
2016-07-18 13:09 ` Josh Poimboeuf
2016-07-19 0:08 ` Byungchul Park
2016-07-18 2:42 ` Byungchul Park
2016-07-08 15:07 ` Frederic Weisbecker
2016-07-18 2:37 ` Byungchul Park
2016-07-08 14:08 ` Josh Poimboeuf
2016-07-08 14:44 ` Frederic Weisbecker
2016-07-18 3:25 ` Byungchul Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160718032510.GO2279@X58A-UD3R \
--to=byungchul.park@lge.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox