From: Peter Zijlstra <peterz@infradead.org>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: linux-kernel@vger.kernel.org, "x86@kernel.org" <x86@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
Paul Turner <pjt@google.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG
Date: Thu, 4 Aug 2016 16:43:25 +0200 [thread overview]
Message-ID: <20160804144325.GP6862@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1470105895-71379-3-git-send-email-davidcc@google.com>
On Mon, Aug 01, 2016 at 07:44:54PM -0700, David Carrillo-Cisneros wrote:
> +++ b/include/linux/perf_event.h
> @@ -681,9 +681,21 @@ struct perf_event {
> #endif
>
> struct list_head sb_list;
> +
> + /* Per-event flags to generic code set by PMU. */
> + int pmu_event_flags;
> +
It appears to me we already have group_flags and attach_state which both
are serialized by ctx->lock.
Could we maybe merge the lot into one flags field?
next prev parent reply other threads:[~2016-08-04 15:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 2:44 [PATCH 0/3] remove unnecessary IPI reading uncore events David Carrillo-Cisneros
2016-08-02 2:44 ` [PATCH 1/3] perf/core: check return value of perf_event_read IPI David Carrillo-Cisneros
2016-08-02 2:44 ` [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG David Carrillo-Cisneros
2016-08-04 14:43 ` Peter Zijlstra [this message]
2016-08-04 17:24 ` David Carrillo-Cisneros
2016-08-04 15:00 ` Peter Zijlstra
2016-08-04 17:23 ` David Carrillo-Cisneros
2016-08-04 17:27 ` Peter Zijlstra
2016-08-04 17:49 ` David Carrillo-Cisneros
2016-08-04 15:11 ` Peter Zijlstra
2016-08-02 2:44 ` [PATCH 3/3] perf/x86: use PMUEF_READ_CPU_PKG in uncore events David Carrillo-Cisneros
2016-08-02 15:11 ` [PATCH 0/3] remove unnecessary IPI reading " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804144325.GP6862@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=davidcc@google.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox