From: Peter Zijlstra <peterz@infradead.org>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
Paul Turner <pjt@google.com>,
Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG
Date: Thu, 4 Aug 2016 19:27:07 +0200 [thread overview]
Message-ID: <20160804172707.GQ6879@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <CALcN6mhjsUtV4A7f2o1rKLobtfjxDWxyfL-LW_yNRj2ZpaYYag@mail.gmail.com>
On Thu, Aug 04, 2016 at 10:23:43AM -0700, David Carrillo-Cisneros wrote:
> >> Introduce the flag PMUEF_READ_CPU_PKG, useful for uncore events, that
> >> allows a PMU to signal the generic perf code that an event is readable
> >> on the current CPU if the event is:
> >> - active in a CPU in the same package as the current CPU (local CPU)
> >
> > Ok that I get..
> >
> >> - not active but is attached to a CPU (i.e. event->cpu != -1) in the
> >> same package as the current CPU.
> >
> > but this, not so much. Why would you want to read an inactive counter?
>
> Uncore counters are active even if its event is not.
Not in general they are not, and if they are (freerunning msr counters
for example) we should not include the counts when the event is
inactive.
next prev parent reply other threads:[~2016-08-04 17:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 2:44 [PATCH 0/3] remove unnecessary IPI reading uncore events David Carrillo-Cisneros
2016-08-02 2:44 ` [PATCH 1/3] perf/core: check return value of perf_event_read IPI David Carrillo-Cisneros
2016-08-02 2:44 ` [PATCH 2/3] perf/core: introduce pmu_event_flags and PMUEF_READ_CPU_PKG David Carrillo-Cisneros
2016-08-04 14:43 ` Peter Zijlstra
2016-08-04 17:24 ` David Carrillo-Cisneros
2016-08-04 15:00 ` Peter Zijlstra
2016-08-04 17:23 ` David Carrillo-Cisneros
2016-08-04 17:27 ` Peter Zijlstra [this message]
2016-08-04 17:49 ` David Carrillo-Cisneros
2016-08-04 15:11 ` Peter Zijlstra
2016-08-02 2:44 ` [PATCH 3/3] perf/x86: use PMUEF_READ_CPU_PKG in uncore events David Carrillo-Cisneros
2016-08-02 15:11 ` [PATCH 0/3] remove unnecessary IPI reading " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804172707.GQ6879@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=ak@linux.intel.com \
--cc=davidcc@google.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox