From: Daniel Vetter <daniel@ffwll.ch>
To: David Binderman <linuxdev.baldrick@gmail.com>
Cc: daniel.vetter@intel.com, jani.nikula@linux.intel.com,
David Airlie <airlied@linux.ie>,
dcb314@hotmail.com, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-gfx] include/drm/i915_drm.h:96: possible bad bitmask ?
Date: Mon, 8 Aug 2016 11:40:27 +0200 [thread overview]
Message-ID: <20160808094027.GA6232@phenom.ffwll.local> (raw)
In-Reply-To: <CAMzoamaAMS7_Oj65hbsmC4Xfsoh6Q2mLz7dL=gWe56S+=-KmBA@mail.gmail.com>
On Mon, Aug 08, 2016 at 10:31:32AM +0100, David Binderman wrote:
> Hello there,
>
> Recent versions of gcc say this:
>
> include/drm/i915_drm.h:96:34: warning: result of ‘65535 << 20’
> requires 37 bits to represent, but ‘int’ only has 32 bits
> [-Wshift-overflow=]
>
> Source code is
>
> #define INTEL_BSM_MASK (0xFFFF << 20)
>
> Maybe something like
>
> #define INTEL_BSM_MASK (0xFFFFUL<< 20)
>
> might be better.
Yup. Care to bake this into a patch (with s-o-b and everything per
Documentation/SubmittingPatches) so I can apply it?
-Daniel
>
>
> Regards
>
> David Binderman
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2016-08-08 9:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-08 9:31 include/drm/i915_drm.h:96: possible bad bitmask ? David Binderman
2016-08-08 9:40 ` Daniel Vetter [this message]
2016-08-09 2:59 ` [Intel-gfx] " Dave Airlie
2016-08-09 16:01 ` Dave Gordon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160808094027.GA6232@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dcb314@hotmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxdev.baldrick@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox