From: Lee Jones <lee.jones@linaro.org>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: broonie@kernel.org, robh@kernel.org, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, ideal.song@samsung.com,
inki.dae@samsung.com, b.zolnierkie@samsung.com,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Beomho Seo <beomho.seo@samsung.com>
Subject: Re: [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver
Date: Tue, 9 Aug 2016 21:50:31 +0100 [thread overview]
Message-ID: <20160809205031.GD1581@dell> (raw)
In-Reply-To: <61d700f7-ef66-8278-54ea-8e6e2f1a029e@samsung.com>
On Tue, 09 Aug 2016, Sylwester Nawrocki wrote:
> On 08/09/2016 05:05 PM, Lee Jones wrote:
> >> +static SIMPLE_DEV_PM_OPS(lpass_pm_ops, exynos_lpass_suspend,
> >> > + exynos_lpass_resume);
> > Put this up by the PM functions.
>
> Sorry, I don't understand this comment, which PM functions do you
> mean exactly?
*_suspend and *_resume. PM == Power Management.
You also need to place the functions in side some CONFIG_PM_SLEEP
guards. Grep around, you'll see what I mean.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-08-09 20:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 17:13 [PATCH v4 2/4] mfd: Add Samsung Exynos Low Power Audio Subsystem driver Sylwester Nawrocki
2016-07-20 15:11 ` Sylwester Nawrocki
2016-07-21 12:11 ` Lee Jones
2016-08-09 15:05 ` Lee Jones
2016-08-09 15:36 ` Sylwester Nawrocki
2016-08-09 20:50 ` Lee Jones [this message]
2016-08-10 8:36 ` Sylwester Nawrocki
2016-08-10 11:19 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809205031.GD1581@dell \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=b.zolnierkie@samsung.com \
--cc=beomho.seo@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ideal.song@samsung.com \
--cc=inki.dae@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox