* [PATCH] edac: wq: Remove deprecated create_singlethread_workqueue
@ 2016-08-13 16:41 Bhaktipriya Shridhar
2016-08-15 5:22 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Bhaktipriya Shridhar @ 2016-08-13 16:41 UTC (permalink / raw)
To: Doug Thompson, Borislav Petkov, Mauro Carvalho Chehab
Cc: linux-edac, linux-kernel, Tejun Heo
alloc_ordered_workqueue() with WQ_MEM_RECLAIM set replaces
deprecated create_singlethread_workqueue(). This is the identity
conversion.
wq has been identity converted since it is used to detect things like
ECC memory errors. It's not recommended to stall it from memory pressure.
Hence, WQ_MEM_RECLAIM has been set to ensure forward progress under
memory pressure.
Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
---
drivers/edac/wq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/edac/wq.c b/drivers/edac/wq.c
index 1b8c07e..2a9a11a 100644
--- a/drivers/edac/wq.c
+++ b/drivers/edac/wq.c
@@ -27,7 +27,7 @@ EXPORT_SYMBOL_GPL(edac_stop_work);
int edac_workqueue_setup(void)
{
- wq = create_singlethread_workqueue("edac-poller");
+ wq = alloc_ordered_workqueue("edac-poller", WQ_MEM_RECLAIM);
if (!wq)
return -ENODEV;
else
--
2.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] edac: wq: Remove deprecated create_singlethread_workqueue
2016-08-13 16:41 [PATCH] edac: wq: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
@ 2016-08-15 5:22 ` Borislav Petkov
0 siblings, 0 replies; 2+ messages in thread
From: Borislav Petkov @ 2016-08-15 5:22 UTC (permalink / raw)
To: Bhaktipriya Shridhar
Cc: Doug Thompson, Mauro Carvalho Chehab, linux-edac, linux-kernel,
Tejun Heo
On Sat, Aug 13, 2016 at 10:11:24PM +0530, Bhaktipriya Shridhar wrote:
> alloc_ordered_workqueue() with WQ_MEM_RECLAIM set replaces
> deprecated create_singlethread_workqueue(). This is the identity
> conversion.
>
> wq has been identity converted since it is used to detect things like
> ECC memory errors. It's not recommended to stall it from memory pressure.
> Hence, WQ_MEM_RECLAIM has been set to ensure forward progress under
> memory pressure.
>
> Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
> ---
> drivers/edac/wq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-08-15 5:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-13 16:41 [PATCH] edac: wq: Remove deprecated create_singlethread_workqueue Bhaktipriya Shridhar
2016-08-15 5:22 ` Borislav Petkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox