From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Binoy Jayan <binoy.jayan@linaro.org>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Florian Schilhabel <florian.c.schilhabel@googlemail.com>,
driverdev-devel@linuxdriverproject.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2 4/4] rtl8712: pwrctrl_priv: Replace semaphore lock with mutex
Date: Sun, 21 Aug 2016 18:26:21 +0200 [thread overview]
Message-ID: <20160821162621.GA13201@kroah.com> (raw)
In-Reply-To: <1464841450-24772-5-git-send-email-binoy.jayan@linaro.org>
On Thu, Jun 02, 2016 at 09:54:10AM +0530, Binoy Jayan wrote:
> The semaphore 'lock' in 'pwrctrl_priv' is used as a simple mutex, so it
> should be written as one. Semaphores are going away in the future.
> _enter_pwrlock was using down_interruptible(), so the lock could be broken
> by sending a signal. This could be a bug, because nothing checks the return
> code here. Hence, using mutex_lock instead of the interruptible version.
> Removing the now unused _enter_pwrlock and _down_sema.
>
> Signed-off-by: Binoy Jayan <binoy.jayan@linaro.org>
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>
> Tested-by: Larry Finger <Larry.Finger@lwfinger.net>
> ---
> This patch depends on the following patch:
> rtl8712: intf_priv: Replace semaphore lock with completion
This one patch doesn't apply to my tree for some odd reason.
Can you rebase it on my staging-testing branch and resend it?
thanks,
greg k-h
next prev parent reply other threads:[~2016-08-21 21:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 4:24 [PATCH v2 0/4] *** rtl8712: Replace semaphores with mutex / completions *** Binoy Jayan
2016-06-02 4:24 ` [PATCH v2 1/4] rtl8712: Replace semaphore cmd_queue_sema with completion Binoy Jayan
2016-06-02 4:24 ` [PATCH v2 2/4] rtl8712: Replace semaphore terminate_cmdthread_sema " Binoy Jayan
2016-06-02 4:24 ` [PATCH v2 3/4] rtl8712: intf_priv: Replace semaphore lock " Binoy Jayan
2016-06-02 4:24 ` [PATCH v2 4/4] rtl8712: pwrctrl_priv: Replace semaphore lock with mutex Binoy Jayan
2016-08-21 16:26 ` Greg Kroah-Hartman [this message]
2016-06-02 7:43 ` [PATCH v2 0/4] *** rtl8712: Replace semaphores with mutex / completions *** Arnd Bergmann
2016-06-02 15:15 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160821162621.GA13201@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=binoy.jayan@linaro.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=florian.c.schilhabel@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox