public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Anson Jacob <ansonjacob.aj@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: i4l: act2000: Fix checkpatch warning
Date: Wed, 31 Aug 2016 09:19:21 +0200	[thread overview]
Message-ID: <20160831071921.GA12128@kroah.com> (raw)
In-Reply-To: <943b3c1845c5482ade5d8b7a628c4f9a88701b61.1472598265.git.ansonjacob.aj@gmail.com>

On Tue, Aug 30, 2016 at 07:04:55PM -0400, Anson Jacob wrote:
> Fix checkpatch.pl warning:
> braces {} are not necessary for single statement blocks
> Missing a blank line after declarations
> 
> Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
> ---
>  drivers/staging/i4l/act2000/act2000_isa.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

You sent 2 patches that do different things, yet have identical subject
lines :(

Please fix that up and send it as a series of 2 patches, with different
subjects, so it makes more sense.

thanks,

greg k-h

  reply	other threads:[~2016-08-31  7:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-30 23:04 [PATCH] staging: i4l: act2000: Fix checkpatch warning Anson Jacob
2016-08-31  7:19 ` Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-08-30 22:58 Anson Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160831071921.GA12128@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=ansonjacob.aj@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox