[PATCH] staging: i4l: act2000: Fix checkpatch warning

[PATCH] staging: i4l: act2000: Fix checkpatch warning

[Anson Jacob]

Fix checkpatch.pl warning:
braces {} are not necessary for single statement blocks
Missing a blank line after declarations

Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
 drivers/staging/i4l/act2000/act2000_isa.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/i4l/act2000/act2000_isa.c b/drivers/staging/i4l/act2000/act2000_isa.c
index f0eb844..fbb15f5 100644
--- a/drivers/staging/i4l/act2000/act2000_isa.c
+++ b/drivers/staging/i4l/act2000/act2000_isa.c
@@ -134,9 +134,9 @@ act2000_isa_config_irq(act2000_card *card, short irq)
 {
 	int old_irq;
 
-	if (card->flags & ACT2000_FLAGS_IVALID) {
+	if (card->flags & ACT2000_FLAGS_IVALID)
 		free_irq(card->irq, card);
-	}
+
 	card->flags &= ~ACT2000_FLAGS_IVALID;
 	outb(ISA_COR_IRQOFF, ISA_PORT_COR);
 	if (!irq)
@@ -259,6 +259,7 @@ act2000_isa_receive(act2000_card *card)
 					       "act2000_isa_receive: Invalid CAPI msg\n");
 					{
 						int i; __u8 *p; __u8 *t; __u8 tmp[30];
+
 						for (i = 0, p = (__u8 *)&card->idat.isa.rcvhdr, t = tmp; i < 8; i++)
 							t += sprintf(t, "%02x ", *(p++));
 						printk(KERN_WARNING "act2000_isa_receive: %s\n", tmp);
-- 
2.7.4

Re: [PATCH] staging: i4l: act2000: Fix checkpatch warning

[Greg KH]

On Tue, Aug 30, 2016 at 07:04:55PM -0400, Anson Jacob wrote:
> Fix checkpatch.pl warning:
> braces {} are not necessary for single statement blocks
> Missing a blank line after declarations
> 
> Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
> ---
>  drivers/staging/i4l/act2000/act2000_isa.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

You sent 2 patches that do different things, yet have identical subject
lines :(

Please fix that up and send it as a series of 2 patches, with different
subjects, so it makes more sense.

thanks,

greg k-h

[PATCH] staging: i4l: act2000: Fix checkpatch warning

[Anson Jacob]

Fix checkpatch.pl warning:
line over 80 characters

Signed-off-by: Anson Jacob <ansonjacob.aj@gmail.com>
---
 drivers/staging/i4l/act2000/act2000.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/i4l/act2000/act2000.h b/drivers/staging/i4l/act2000/act2000.h
index 321d437..16be456 100644
--- a/drivers/staging/i4l/act2000/act2000.h
+++ b/drivers/staging/i4l/act2000/act2000.h
@@ -198,5 +198,5 @@ static inline void act2000_schedule_poll(act2000_card *card)
 
 extern char *act2000_find_eaz(act2000_card *, char);
 
-#endif                          /* defined(__KERNEL__) || defined(__DEBUGVAR__) */
-#endif                          /* act2000_h */
+#endif                       /* defined(__KERNEL__) || defined(__DEBUGVAR__) */
+#endif                       /* act2000_h */
-- 
2.7.4