From: Huang Rui <ray.huang@amd.com>
To: Baoyou Xie <baoyou.xie@linaro.org>
Cc: <alexander.deucher@amd.com>, <christian.koenig@amd.com>,
<airlied@linux.ie>, <Rex.Zhu@amd.com>, <Jammy.Zhou@amd.com>,
<elfring@users.sourceforge.net>, <Young.Yang@amd.com>,
<airlied@redhat.com>, <Mykola.Lysenko@amd.com>,
<dan.carpenter@oracle.com>, <David1.Zhou@amd.com>,
<Monk.Liu@amd.com>, <Jerry.Zhang@amd.com>, <samuel.li@amd.com>,
<tom.stdenis@amd.com>, <Flora.Cui@amd.com>,
<JinHuiEric.Huang@amd.com>, <funfunctor@folklore1984.net>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<arnd@arndb.de>, <xie.baoyou@zte.com.cn>
Subject: Re: [PATCH] drm: amdgpu: mark symbols static where possible
Date: Sat, 3 Sep 2016 17:10:11 +0800 [thread overview]
Message-ID: <20160903091010.GA3730@hr-amur2> (raw)
In-Reply-To: <1472882234-19385-1-git-send-email-baoyou.xie@linaro.org>
On Sat, Sep 03, 2016 at 01:57:14PM +0800, Baoyou Xie wrote:
> We get a few warnings when building kernel with W=1:
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:51:5: warning: no previous prototype for 'cz_send_msg_to_smc_async' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/cz_smc.c:143:5: warning: no previous prototype for 'cz_write_smc_sram_dword' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/iceland_smc.c:124:6: warning: no previous prototype for 'iceland_start_smc' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c:3926:6: warning: no previous prototype for 'gfx_v8_0_rlc_stop' [-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/amdgpu_job.c:94:6: warning: no previous prototype for 'amdgpu_job_free_cb' [-Wmissing-prototypes]
> ....
>
> In fact, these functions are only used in the file in which they are
> declared and don't need a declaration, but can be made static.
> So this patch marks these functions with 'static'.
>
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
Thanks.
Acked-by: Huang Rui <ray.huang@amd.com>
prev parent reply other threads:[~2016-09-03 9:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-03 5:57 [PATCH] drm: amdgpu: mark symbols static where possible Baoyou Xie
2016-09-03 6:11 ` Edward O'Callaghan
[not found] ` <CA+DQWkyb7xV_9o7dE4rfiy33=8_q5sfpWoTgbW8zig3f2FAoMQ@mail.gmail.com>
2016-09-03 6:44 ` Edward O'Callaghan
2016-09-03 8:12 ` Christian König
2016-09-03 9:10 ` Huang Rui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160903091010.GA3730@hr-amur2 \
--to=ray.huang@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Flora.Cui@amd.com \
--cc=Jammy.Zhou@amd.com \
--cc=Jerry.Zhang@amd.com \
--cc=JinHuiEric.Huang@amd.com \
--cc=Monk.Liu@amd.com \
--cc=Mykola.Lysenko@amd.com \
--cc=Rex.Zhu@amd.com \
--cc=Young.Yang@amd.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=christian.koenig@amd.com \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=funfunctor@folklore1984.net \
--cc=linux-kernel@vger.kernel.org \
--cc=samuel.li@amd.com \
--cc=tom.stdenis@amd.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox