From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Baoyou Xie <baoyou.xie@linaro.org>,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn,
Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH] drm/atmel-hlcdc: mark atmel_hlcdc_crtc_reset() static
Date: Tue, 6 Sep 2016 15:50:30 +0200 [thread overview]
Message-ID: <20160906155030.01501417@bbrezillon> (raw)
In-Reply-To: <5193604.cj3c1WipcO@wuerfel>
On Tue, 06 Sep 2016 15:43:45 +0200
Arnd Bergmann <arnd@arndb.de> wrote:
> On Tuesday, September 6, 2016 3:46:16 PM CEST Baoyou Xie wrote:
> > We get 1 warning when building kernel with W=1:
> > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c:390:6: warning: no previous prototype for 'atmel_hlcdc_crtc_reset' [-Wmissing-prototypes]
> >
> > In fact, this function is only used in the file in which it is
> > declared and don't need a declaration, but can be made static.
> > So this patch marks it 'static'.
> >
> > Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> >
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
Actually, Thierry already posted the same patch a while ago. I just
sent a PR to Dave containing this patch.
prev parent reply other threads:[~2016-09-06 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 7:46 [PATCH] drm/atmel-hlcdc: mark atmel_hlcdc_crtc_reset() static Baoyou Xie
2016-09-06 13:43 ` Arnd Bergmann
2016-09-06 13:50 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906155030.01501417@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thierry.reding@gmail.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox