Re: [PATCH] nvme/quirk: Add a delay before checking device ready for memblaze device

Re: [PATCH] nvme/quirk: Add a delay before checking device ready for memblaze device

[Keith Busch]

On Thu, Sep 08, 2016 at 11:36:34AM +0800, Wang Weber wrote:
> Hi Jens,
> 
> The following email was sent before, but it seems to be blocked since I
> received some messages about sending failure. So resend it with Google
> email account.

You're still sending non plain text email, so it's going to be rejected
by the mailing list filter. It also mangles your patch such that it
won't cleanly apply. You have to use plain text for this to work well.

Re: [PATCH] nvme/quirk: Add a delay before checking device ready for memblaze device

[Jens Axboe]

On 09/08/2016 08:36 AM, Keith Busch wrote:
> On Thu, Sep 08, 2016 at 11:36:34AM +0800, Wang Weber wrote:
>> Hi Jens,
>>
>> The following email was sent before, but it seems to be blocked since I
>> received some messages about sending failure. So resend it with Google
>> email account.
>
> You're still sending non plain text email, so it's going to be rejected
> by the mailing list filter. It also mangles your patch such that it
> won't cleanly apply. You have to use plain text for this to work well.

Indeed. And in addition to it being rejected by the reflector, it also
means your patch is mangled.

-- 
Jens Axboe

Re: [PATCH] nvme/quirk: Add a delay before checking device ready for memblaze device

[Jens Axboe]

On 09/08/2016 08:30 AM, Jens Axboe wrote:
> On 09/08/2016 08:36 AM, Keith Busch wrote:
>> On Thu, Sep 08, 2016 at 11:36:34AM +0800, Wang Weber wrote:
>>> Hi Jens,
>>>
>>> The following email was sent before, but it seems to be blocked since I
>>> received some messages about sending failure. So resend it with Google
>>> email account.
>>
>> You're still sending non plain text email, so it's going to be rejected
>> by the mailing list filter. It also mangles your patch such that it
>> won't cleanly apply. You have to use plain text for this to work well.
>
> Indeed. And in addition to it being rejected by the reflector, it also
> means your patch is mangled.

I guess Keith already made that point too on the patch mangling, needs
more coffee. Also, it mangles the patch.

-- 
Jens Axboe

[PATCH] nvme/quirk: Add a delay before checking device ready for memblaze device

[Wenbo Wang]

From: Wenbo Wang <wenbo.wang@memblaze.com>

Signed-off-by: Wenbo Wang <wenbo.wang@memblaze.com>
---
 drivers/nvme/host/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 663c40c..2fec23c 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2141,6 +2141,8 @@ static const struct pci_device_id nvme_id_table[] = {
 		.driver_data = NVME_QUIRK_IDENTIFY_CNS, },
 	{ PCI_DEVICE(0x1c58, 0x0003),	/* HGST adapter */
 		.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
+	{ PCI_DEVICE(0x1c5f, 0x0540),	/* Memblaze Pblaze4 adapter */
+		.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
 	{ PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
 	{ 0, }
-- 
1.8.3.1

Re: [PATCH] nvme/quirk: Add a delay before checking device ready for memblaze device

[Jens Axboe]

On 09/08/2016 10:12 AM, Wenbo Wang wrote:
> From: Wenbo Wang <wenbo.wang@memblaze.com>
>
> Signed-off-by: Wenbo Wang <wenbo.wang@memblaze.com>
> ---
>  drivers/nvme/host/pci.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 663c40c..2fec23c 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -2141,6 +2141,8 @@ static const struct pci_device_id nvme_id_table[] = {
>  		.driver_data = NVME_QUIRK_IDENTIFY_CNS, },
>  	{ PCI_DEVICE(0x1c58, 0x0003),	/* HGST adapter */
>  		.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
> +	{ PCI_DEVICE(0x1c5f, 0x0540),	/* Memblaze Pblaze4 adapter */
> +		.driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
>  	{ PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
>  	{ PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
>  	{ 0, }

Thanks, applied for 4.8.

-- 
Jens Axboe

RE: [PATCH] nvme/quirk: Add a delay before checking device ready for memblaze device

[Wenbo Wang]

Keith,

Is this patch accepted? Thanks.

-----Original Message-----
From: Wenbo Wang 
Sent: Tuesday, August 9, 2016 11:18 AM
To: 'keith.busch@intel.com'; 'axboe@fb.com'
Cc: linux-nvme@lists.infradead.org; linux-kernel@vger.kernel.org
Subject: [PATCH] nvme/quirk: Add a delay before checking device ready for memblaze device

Add a delay before checking device ready for memblaze device


Signed-off-by: Wenbo Wang <wenbo.wang@memblaze.com>
---
 drivers/nvme/host/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c index c82282f..ab90e5f 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2154,6 +2154,8 @@ static const struct pci_device_id nvme_id_table[] = {
        .driver_data = NVME_QUIRK_IDENTIFY_CNS, },
    { PCI_DEVICE(0x1c58, 0x0003),   /* HGST adapter */
        .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
+   { PCI_DEVICE(0x1c5f, 0x0540),   /* Memblaze Pblaze4 adapter */
+       .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
    { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
    { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
    { 0, }
--
1.8.3.1

Re: [PATCH] nvme/quirk: Add a delay before checking device ready for memblaze device

[Keith Busch]

On Mon, Aug 15, 2016 at 05:21:07AM +0000, Wenbo Wang wrote:
> Keith,
> 
> Is this patch accepted? Thanks.

The patch looks fine, though Jens has to apply these. I'm just an
ostensibly glorified reviewer. :)

Reviewed-by: Keith Busch <keith.busch@intel.com>

[PATCH] nvme/quirk: Add a delay before checking device ready for memblaze device

[Wenbo Wang]

Add a delay before checking device ready for memblaze device


Signed-off-by: Wenbo Wang <wenbo.wang@memblaze.com>
---
 drivers/nvme/host/pci.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index c82282f..ab90e5f 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2154,6 +2154,8 @@ static const struct pci_device_id nvme_id_table[] = {
        .driver_data = NVME_QUIRK_IDENTIFY_CNS, },
    { PCI_DEVICE(0x1c58, 0x0003),   /* HGST adapter */
        .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
+   { PCI_DEVICE(0x1c5f, 0x0540),   /* Memblaze Pblaze4 adapter */
+       .driver_data = NVME_QUIRK_DELAY_BEFORE_CHK_RDY, },
    { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
    { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001) },
    { 0, }
--
1.8.3.1