From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: "Lee Jones" <lee.jones@linaro.org>,
linaro-kernel@lists.linaro.org, "Mark Brown" <broonie@kernel.org>,
"Krzysztof Kozłowski" <k.kozlowski@samsung.com>,
patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mfd: wm8994-core: disable regulators before removing them
Date: Thu, 15 Sep 2016 13:31:55 +0100 [thread overview]
Message-ID: <20160915123155.GP21682@localhost.localdomain> (raw)
In-Reply-To: <9f4aa8441344137272549e65d81c7fe65e37a8a8.1473938123.git.viresh.kumar@linaro.org>
On Thu, Sep 15, 2016 at 04:47:00PM +0530, Viresh Kumar wrote:
> The order in which resources were freed in wm8994_device_exit() isn't
> correct. The regulators are removed before they are disabled.
>
> Fix it by reordering code a bit, which makes it exact opposite of
> wm8994_device_init() as well.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
prev parent reply other threads:[~2016-09-15 12:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-15 11:17 [PATCH 1/2] mfd: wm8994-core: disable regulators before removing them Viresh Kumar
2016-09-15 11:17 ` [PATCH 2/2] mfd: wm8994-core: Don't use managed regulator bulk get API Viresh Kumar
2016-09-15 12:34 ` Charles Keepax
2016-09-15 14:47 ` Mark Brown
2016-09-15 15:08 ` Viresh Kumar
2016-09-15 15:47 ` Mark Brown
2016-09-15 12:31 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160915123155.GP21682@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=broonie@kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox