* [PATCH] scripts/recordmcount.c: account for .softirqentry.text
@ 2016-09-26 9:13 Dmitry Vyukov
2016-09-26 15:02 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Vyukov @ 2016-09-26 9:13 UTC (permalink / raw)
To: rostedt, mingo, akpm
Cc: linux-kernel, ryabinin.a.a, surovegin, Dmitry Vyukov, stable, #,
v4.6+
Commit "arch, ftrace: for KASAN put hard/soft IRQ entries into separate sections"
added .softirqentry.text section, but it was not added to recordmcount.
So functions in the section are untracable.
Add the section to scripts/recordmcount.c.
Fixes: be7635e7287e ("arch, ftrace: for KASAN put hard/soft IRQ entries into separate sections")
Cc: stable@vger.kernel.org # v4.6+
Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
---
scripts/recordmcount.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
index 42396a7..a68f031 100644
--- a/scripts/recordmcount.c
+++ b/scripts/recordmcount.c
@@ -363,6 +363,7 @@ is_mcounted_section_name(char const *const txtname)
strcmp(".sched.text", txtname) == 0 ||
strcmp(".spinlock.text", txtname) == 0 ||
strcmp(".irqentry.text", txtname) == 0 ||
+ strcmp(".softirqentry.text", txtname) == 0 ||
strcmp(".kprobes.text", txtname) == 0 ||
strcmp(".text.unlikely", txtname) == 0;
}
--
2.8.0.rc3.226.g39d4020
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scripts/recordmcount.c: account for .softirqentry.text
2016-09-26 9:13 [PATCH] scripts/recordmcount.c: account for .softirqentry.text Dmitry Vyukov
@ 2016-09-26 15:02 ` Steven Rostedt
2016-09-26 15:06 ` Steven Rostedt
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2016-09-26 15:02 UTC (permalink / raw)
To: Dmitry Vyukov; +Cc: mingo, akpm, linux-kernel, ryabinin.a.a, surovegin, stable
On Mon, 26 Sep 2016 11:13:15 +0200
Dmitry Vyukov <dvyukov@google.com> wrote:
> Commit "arch, ftrace: for KASAN put hard/soft IRQ entries into separate sections"
> added .softirqentry.text section, but it was not added to recordmcount.
> So functions in the section are untracable.
> Add the section to scripts/recordmcount.c.
>
> Fixes: be7635e7287e ("arch, ftrace: for KASAN put hard/soft IRQ entries into separate sections")
> Cc: stable@vger.kernel.org # v4.6+
> Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
I'm currently traveling and wont have time to process this any time
soon. But it looks good to me.
Acked-by: Steve Rostedt <rostedt@goodmis.org>
If someone else wants to pull this into their tree I'm fine with that.
It doesn't look like I would have to run this through my test suite.
I'm fine with the stable tag too.
-- Steve
> ---
> scripts/recordmcount.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> index 42396a7..a68f031 100644
> --- a/scripts/recordmcount.c
> +++ b/scripts/recordmcount.c
> @@ -363,6 +363,7 @@ is_mcounted_section_name(char const *const txtname)
> strcmp(".sched.text", txtname) == 0 ||
> strcmp(".spinlock.text", txtname) == 0 ||
> strcmp(".irqentry.text", txtname) == 0 ||
> + strcmp(".softirqentry.text", txtname) == 0 ||
> strcmp(".kprobes.text", txtname) == 0 ||
> strcmp(".text.unlikely", txtname) == 0;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] scripts/recordmcount.c: account for .softirqentry.text
2016-09-26 15:02 ` Steven Rostedt
@ 2016-09-26 15:06 ` Steven Rostedt
2016-09-26 15:11 ` Dmitry Vyukov
0 siblings, 1 reply; 4+ messages in thread
From: Steven Rostedt @ 2016-09-26 15:06 UTC (permalink / raw)
To: Dmitry Vyukov; +Cc: mingo, akpm, linux-kernel, ryabinin.a.a, surovegin, stable
On Mon, 26 Sep 2016 11:02:36 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> > ---
> > scripts/recordmcount.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
> > index 42396a7..a68f031 100644
> > --- a/scripts/recordmcount.c
> > +++ b/scripts/recordmcount.c
> > @@ -363,6 +363,7 @@ is_mcounted_section_name(char const *const txtname)
> > strcmp(".sched.text", txtname) == 0 ||
> > strcmp(".spinlock.text", txtname) == 0 ||
> > strcmp(".irqentry.text", txtname) == 0 ||
> > + strcmp(".softirqentry.text", txtname) == 0 ||
> > strcmp(".kprobes.text", txtname) == 0 ||
> > strcmp(".text.unlikely", txtname) == 0;
> > }
>
Oh, some archs still use recordmcount.pl. I'm guessing that needs to be
updated too:
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
index 96e2486..2d48011 100755
--- a/scripts/recordmcount.pl
+++ b/scripts/recordmcount.pl
@@ -134,6 +134,7 @@ my %text_sections = (
".sched.text" => 1,
".spinlock.text" => 1,
".irqentry.text" => 1,
+ ".softirqentry.text" => 1,
".kprobes.text" => 1,
".text.unlikely" => 1,
);
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] scripts/recordmcount.c: account for .softirqentry.text
2016-09-26 15:06 ` Steven Rostedt
@ 2016-09-26 15:11 ` Dmitry Vyukov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Vyukov @ 2016-09-26 15:11 UTC (permalink / raw)
To: Steven Rostedt
Cc: Ingo Molnar, Andrew Morton, LKML, Andrey Ryabinin,
Eugene Surovegin, stable
On Mon, Sep 26, 2016 at 5:06 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Mon, 26 Sep 2016 11:02:36 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
>> > ---
>> > scripts/recordmcount.c | 1 +
>> > 1 file changed, 1 insertion(+)
>> >
>> > diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
>> > index 42396a7..a68f031 100644
>> > --- a/scripts/recordmcount.c
>> > +++ b/scripts/recordmcount.c
>> > @@ -363,6 +363,7 @@ is_mcounted_section_name(char const *const txtname)
>> > strcmp(".sched.text", txtname) == 0 ||
>> > strcmp(".spinlock.text", txtname) == 0 ||
>> > strcmp(".irqentry.text", txtname) == 0 ||
>> > + strcmp(".softirqentry.text", txtname) == 0 ||
>> > strcmp(".kprobes.text", txtname) == 0 ||
>> > strcmp(".text.unlikely", txtname) == 0;
>> > }
>>
>
> Oh, some archs still use recordmcount.pl. I'm guessing that needs to be
> updated too:
>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
> ---
> diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
> index 96e2486..2d48011 100755
> --- a/scripts/recordmcount.pl
> +++ b/scripts/recordmcount.pl
> @@ -134,6 +134,7 @@ my %text_sections = (
> ".sched.text" => 1,
> ".spinlock.text" => 1,
> ".irqentry.text" => 1,
> + ".softirqentry.text" => 1,
> ".kprobes.text" => 1,
> ".text.unlikely" => 1,
> );
Thanks, Steven. Mailed v2 with recordmcount.pl change.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-26 15:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-26 9:13 [PATCH] scripts/recordmcount.c: account for .softirqentry.text Dmitry Vyukov
2016-09-26 15:02 ` Steven Rostedt
2016-09-26 15:06 ` Steven Rostedt
2016-09-26 15:11 ` Dmitry Vyukov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox