From: Dan Carpenter <dan.carpenter@oracle.com>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
devel@driverdev.osuosl.org, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, Johan Hovold <johan@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] greybus: manifest: style fix missing space before '('
Date: Tue, 27 Sep 2016 12:47:38 +0300 [thread overview]
Message-ID: <20160927094738.GX13620@mwanda> (raw)
In-Reply-To: <728f3214-c9f2-837b-6725-f95777c23bab@gmail.com>
On Tue, Sep 27, 2016 at 11:33:49AM +0200, Quentin Lambert wrote:
>
>
> On 27/09/2016 11:31, Viresh Kumar wrote:
> >On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
> ><lambert.quentin@gmail.com> wrote:
> >>Checkpatch printed a style ERROR concerning a missing space befire '('.
> >>This patch fix this issue.
> >>
> >>Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
> >>---
> >> drivers/staging/greybus/manifest.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>--- a/drivers/staging/greybus/manifest.c
> >>+++ b/drivers/staging/greybus/manifest.c
> >>@@ -11,7 +11,7 @@
> >>
> >> static const char *get_descriptor_type_string(u8 type)
> >> {
> >>- switch(type) {
> >>+ switch (type) {
> >> case GREYBUS_TYPE_INVALID:
> >> return "invalid";
> >> case GREYBUS_TYPE_STRING:
> >Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Wow I just noticed the typo: "befire" do you want me to resend ?
No one cares about tiny typos in the patch description, but resend if
you want.
regards,
dan carpenter
next prev parent reply other threads:[~2016-09-27 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 9:20 [PATCH] greybus: manifest: style fix missing space before '(' Quentin Lambert
2016-09-27 9:31 ` Viresh Kumar
2016-09-27 9:33 ` Quentin Lambert
2016-09-27 9:36 ` Viresh Kumar
2016-09-27 9:47 ` Dan Carpenter [this message]
2016-09-27 9:42 ` [PATCH v2] " Quentin Lambert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927094738.GX13620@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox