* [PATCH] greybus: manifest: style fix missing space before '('
@ 2016-09-27 9:20 Quentin Lambert
2016-09-27 9:31 ` Viresh Kumar
2016-09-27 9:42 ` [PATCH v2] " Quentin Lambert
0 siblings, 2 replies; 6+ messages in thread
From: Quentin Lambert @ 2016-09-27 9:20 UTC (permalink / raw)
To: Johan Hovold, Alex Elder, Greg Kroah-Hartman, devel, linux-kernel
Cc: kernel-janitors, Quentin Lambert
Checkpatch printed a style ERROR concerning a missing space befire '('.
This patch fix this issue.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
---
drivers/staging/greybus/manifest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/greybus/manifest.c
+++ b/drivers/staging/greybus/manifest.c
@@ -11,7 +11,7 @@
static const char *get_descriptor_type_string(u8 type)
{
- switch(type) {
+ switch (type) {
case GREYBUS_TYPE_INVALID:
return "invalid";
case GREYBUS_TYPE_STRING:
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] greybus: manifest: style fix missing space before '('
2016-09-27 9:20 [PATCH] greybus: manifest: style fix missing space before '(' Quentin Lambert
@ 2016-09-27 9:31 ` Viresh Kumar
2016-09-27 9:33 ` Quentin Lambert
2016-09-27 9:42 ` [PATCH v2] " Quentin Lambert
1 sibling, 1 reply; 6+ messages in thread
From: Viresh Kumar @ 2016-09-27 9:31 UTC (permalink / raw)
To: Quentin Lambert
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, devel,
linux-kernel@vger.kernel.org, kernel-janitors
On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
<lambert.quentin@gmail.com> wrote:
> Checkpatch printed a style ERROR concerning a missing space befire '('.
> This patch fix this issue.
>
> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
> ---
> drivers/staging/greybus/manifest.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/staging/greybus/manifest.c
> +++ b/drivers/staging/greybus/manifest.c
> @@ -11,7 +11,7 @@
>
> static const char *get_descriptor_type_string(u8 type)
> {
> - switch(type) {
> + switch (type) {
> case GREYBUS_TYPE_INVALID:
> return "invalid";
> case GREYBUS_TYPE_STRING:
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] greybus: manifest: style fix missing space before '('
2016-09-27 9:31 ` Viresh Kumar
@ 2016-09-27 9:33 ` Quentin Lambert
2016-09-27 9:36 ` Viresh Kumar
2016-09-27 9:47 ` Dan Carpenter
0 siblings, 2 replies; 6+ messages in thread
From: Quentin Lambert @ 2016-09-27 9:33 UTC (permalink / raw)
To: Viresh Kumar
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman, devel,
linux-kernel@vger.kernel.org, kernel-janitors
On 27/09/2016 11:31, Viresh Kumar wrote:
> On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
> <lambert.quentin@gmail.com> wrote:
>> Checkpatch printed a style ERROR concerning a missing space befire '('.
>> This patch fix this issue.
>>
>> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
>> ---
>> drivers/staging/greybus/manifest.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/staging/greybus/manifest.c
>> +++ b/drivers/staging/greybus/manifest.c
>> @@ -11,7 +11,7 @@
>>
>> static const char *get_descriptor_type_string(u8 type)
>> {
>> - switch(type) {
>> + switch (type) {
>> case GREYBUS_TYPE_INVALID:
>> return "invalid";
>> case GREYBUS_TYPE_STRING:
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Wow I just noticed the typo: "befire" do you want me to resend ?
Quentin
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] greybus: manifest: style fix missing space before '('
2016-09-27 9:33 ` Quentin Lambert
@ 2016-09-27 9:36 ` Viresh Kumar
2016-09-27 9:47 ` Dan Carpenter
1 sibling, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2016-09-27 9:36 UTC (permalink / raw)
To: Quentin Lambert
Cc: Johan Hovold, Alex Elder, Greg Kroah-Hartman,
open list:ANDROID DRIVERS, linux-kernel@vger.kernel.org,
kernel-janitors
On 27 September 2016 at 15:03, Quentin Lambert
<lambert.quentin@gmail.com> wrote:
>
>
> On 27/09/2016 11:31, Viresh Kumar wrote:
>>
>> On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
>> <lambert.quentin@gmail.com> wrote:
>>>
>>> Checkpatch printed a style ERROR concerning a missing space befire '('.
>>> This patch fix this issue.
>>>
>>> Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
>>> ---
>>> drivers/staging/greybus/manifest.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> --- a/drivers/staging/greybus/manifest.c
>>> +++ b/drivers/staging/greybus/manifest.c
>>> @@ -11,7 +11,7 @@
>>>
>>> static const char *get_descriptor_type_string(u8 type)
>>> {
>>> - switch(type) {
>>> + switch (type) {
>>> case GREYBUS_TYPE_INVALID:
>>> return "invalid";
>>> case GREYBUS_TYPE_STRING:
>>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
> Wow I just noticed the typo: "befire" do you want me to resend ?
Oops, sorry for missing that.
Yes, please resend the patch as V2 and feel free to add my Ack to it.
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] greybus: manifest: style fix missing space before '('
2016-09-27 9:33 ` Quentin Lambert
2016-09-27 9:36 ` Viresh Kumar
@ 2016-09-27 9:47 ` Dan Carpenter
1 sibling, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2016-09-27 9:47 UTC (permalink / raw)
To: Quentin Lambert
Cc: Viresh Kumar, devel, Alex Elder, Greg Kroah-Hartman,
kernel-janitors, Johan Hovold, linux-kernel@vger.kernel.org
On Tue, Sep 27, 2016 at 11:33:49AM +0200, Quentin Lambert wrote:
>
>
> On 27/09/2016 11:31, Viresh Kumar wrote:
> >On Tue, Sep 27, 2016 at 2:50 PM, Quentin Lambert
> ><lambert.quentin@gmail.com> wrote:
> >>Checkpatch printed a style ERROR concerning a missing space befire '('.
> >>This patch fix this issue.
> >>
> >>Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
> >>---
> >> drivers/staging/greybus/manifest.c | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >>--- a/drivers/staging/greybus/manifest.c
> >>+++ b/drivers/staging/greybus/manifest.c
> >>@@ -11,7 +11,7 @@
> >>
> >> static const char *get_descriptor_type_string(u8 type)
> >> {
> >>- switch(type) {
> >>+ switch (type) {
> >> case GREYBUS_TYPE_INVALID:
> >> return "invalid";
> >> case GREYBUS_TYPE_STRING:
> >Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Wow I just noticed the typo: "befire" do you want me to resend ?
No one cares about tiny typos in the patch description, but resend if
you want.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] greybus: manifest: style fix missing space before '('
2016-09-27 9:20 [PATCH] greybus: manifest: style fix missing space before '(' Quentin Lambert
2016-09-27 9:31 ` Viresh Kumar
@ 2016-09-27 9:42 ` Quentin Lambert
1 sibling, 0 replies; 6+ messages in thread
From: Quentin Lambert @ 2016-09-27 9:42 UTC (permalink / raw)
To: Viresh Kumar, Johan Hovold, Alex Elder, Greg Kroah-Hartman, devel,
linux-kernel
Cc: kernel-janitors, Quentin Lambert
Checkpatch printed a style ERROR concerning a missing space before '('.
This patch fixes this issue.
Signed-off-by: Quentin Lambert <lambert.quentin@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
---
v2: fixes typos in commit message
drivers/staging/greybus/manifest.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/greybus/manifest.c
+++ b/drivers/staging/greybus/manifest.c
@@ -11,7 +11,7 @@
static const char *get_descriptor_type_string(u8 type)
{
- switch(type) {
+ switch (type) {
case GREYBUS_TYPE_INVALID:
return "invalid";
case GREYBUS_TYPE_STRING:
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-27 9:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-27 9:20 [PATCH] greybus: manifest: style fix missing space before '(' Quentin Lambert
2016-09-27 9:31 ` Viresh Kumar
2016-09-27 9:33 ` Quentin Lambert
2016-09-27 9:36 ` Viresh Kumar
2016-09-27 9:47 ` Dan Carpenter
2016-09-27 9:42 ` [PATCH v2] " Quentin Lambert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox